RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, January 21, 2017 3:11 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; rafael.j.wyso...@intel.com; > pmen...@molgen.mpg.de; li...@leemhuis.info;

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday, January 21, 2017 3:11 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; rafael.j.wyso...@intel.com; > pmen...@molgen.mpg.de; li...@leemhuis.info; tomas.wink...@intel.com; > j...@gondor.com;

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -Original Message- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of > Rafael J. Wysocki > Sent: Sunday, January 22, 2017 3:45 AM > To: Limonciello, Mario > Cc: Greg Kroah-Hartman ; Darren Hart >

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -Original Message- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of > Rafael J. Wysocki > Sent: Sunday, January 22, 2017 3:45 AM > To: Limonciello, Mario > Cc: Greg Kroah-Hartman ; Darren Hart > ; Rafael Wysocki ; Paul > Menzel ; Thorsten Leemhuis > ; Tomas

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 12:49:50PM +0100, Rafael J. Wysocki wrote: > On Sat, Jan 21, 2017 at 10:11 AM, Greg KH wrote: > > On Fri, Jan 20, 2017 at 11:11:45PM +, mario.limoncie...@dell.com wrote: > >> Greg, > >> > >> > -Original Message- > >> > From: Darren

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 12:49:50PM +0100, Rafael J. Wysocki wrote: > On Sat, Jan 21, 2017 at 10:11 AM, Greg KH wrote: > > On Fri, Jan 20, 2017 at 11:11:45PM +, mario.limoncie...@dell.com wrote: > >> Greg, > >> > >> > -Original Message- > >> > From: Darren Hart

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 12:11 AM, wrote: > Greg, > >> -Original Message- >> From: Darren Hart [mailto:dvh...@infradead.org] >> Sent: Tuesday, January 17, 2017 5:34 PM >> To: Limonciello, Mario >> Cc: gre...@linuxfoundation.org;

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 12:11 AM, wrote: > Greg, > >> -Original Message- >> From: Darren Hart [mailto:dvh...@infradead.org] >> Sent: Tuesday, January 17, 2017 5:34 PM >> To: Limonciello, Mario >> Cc: gre...@linuxfoundation.org; rafael.j.wyso...@intel.com; >> pmen...@molgen.mpg.de;

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 10:11 AM, Greg KH wrote: > On Fri, Jan 20, 2017 at 11:11:45PM +, mario.limoncie...@dell.com wrote: >> Greg, >> >> > -Original Message- >> > From: Darren Hart [mailto:dvh...@infradead.org] >> > Sent: Tuesday, January 17, 2017 5:34 PM

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Sat, Jan 21, 2017 at 10:11 AM, Greg KH wrote: > On Fri, Jan 20, 2017 at 11:11:45PM +, mario.limoncie...@dell.com wrote: >> Greg, >> >> > -Original Message- >> > From: Darren Hart [mailto:dvh...@infradead.org] >> > Sent: Tuesday, January 17, 2017 5:34 PM >> > To: Limonciello, Mario

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Fri, Jan 20, 2017 at 11:11:45PM +, mario.limoncie...@dell.com wrote: > Greg, > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Tuesday, January 17, 2017 5:34 PM > > To: Limonciello, Mario > > Cc:

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Fri, Jan 20, 2017 at 11:11:45PM +, mario.limoncie...@dell.com wrote: > Greg, > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Tuesday, January 17, 2017 5:34 PM > > To: Limonciello, Mario > > Cc: gre...@linuxfoundation.org;

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Greg, > -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Tuesday, January 17, 2017 5:34 PM > To: Limonciello, Mario > Cc: gre...@linuxfoundation.org; rafael.j.wyso...@intel.com; > pmen...@molgen.mpg.de; li...@leemhuis.info;

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Greg, > -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Tuesday, January 17, 2017 5:34 PM > To: Limonciello, Mario > Cc: gre...@linuxfoundation.org; rafael.j.wyso...@intel.com; > pmen...@molgen.mpg.de; li...@leemhuis.info; tomas.wink...@intel.com; >

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Mario, thanks for CCing this to linux-pm. On Tue, Jan 17, 2017 at 5:57 PM, wrote: > Hi Paul, > > Thanks for raising this topic and including me. > Suspend to Idle support in Linux as an alternative S3 on x86 is a new > topic. In all, I expected that some problems

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Mario, thanks for CCing this to linux-pm. On Tue, Jan 17, 2017 at 5:57 PM, wrote: > Hi Paul, > > Thanks for raising this topic and including me. > Suspend to Idle support in Linux as an alternative S3 on x86 is a new > topic. In all, I expected that some problems would arise as a result > of

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Tue, Jan 17, 2017 at 06:38:43PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 17, 2017 12:24 PM > > To: Limonciello, Mario > > Cc: pmen...@molgen.mpg.de;

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Tue, Jan 17, 2017 at 06:38:43PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 17, 2017 12:24 PM > > To: Limonciello, Mario > > Cc: pmen...@molgen.mpg.de; rafael.j.wyso...@intel.com; > >

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 17, 2017 12:24 PM > To: Limonciello, Mario > Cc: pmen...@molgen.mpg.de; rafael.j.wyso...@intel.com; > li...@leemhuis.info; tomas.wink...@intel.com;

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 17, 2017 12:24 PM > To: Limonciello, Mario > Cc: pmen...@molgen.mpg.de; rafael.j.wyso...@intel.com; > li...@leemhuis.info; tomas.wink...@intel.com; j...@gondor.com; >

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Tue, Jan 17, 2017 at 04:57:49PM +, mario.limoncie...@dell.com wrote: > So in the <6s scenario, the intel-hid driver is responsible to receive the > ACPI > event and process accordingly. The maintainer has a patch ready for the > intel-hid > portion of this work, but it's currently being

Re: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

On Tue, Jan 17, 2017 at 04:57:49PM +, mario.limoncie...@dell.com wrote: > So in the <6s scenario, the intel-hid driver is responsible to receive the > ACPI > event and process accordingly. The maintainer has a patch ready for the > intel-hid > portion of this work, but it's currently being

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Hi Paul, Thanks for raising this topic and including me. Suspend to Idle support in Linux as an alternative S3 on x86 is a new topic. In all, I expected that some problems would arise as a result of this patch, and I hope they will spur interesting discussions and solutions. Something that

RE: Regression on Dell XPS13 (was: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer)

Hi Paul, Thanks for raising this topic and including me. Suspend to Idle support in Linux as an alternative S3 on x86 is a new topic. In all, I expected that some problems would arise as a result of this patch, and I hope they will spur interesting discussions and solutions. Something that

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Greg Kroah-Hartman wrote on 16.01.2017 12:05: > On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote: >> On Sun, Jan 15, 2017 at 07:19:03AM +, Winkler, Tomas wrote: >> > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version >> > > only for SPT >> > > and newer

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Greg Kroah-Hartman wrote on 16.01.2017 12:05: > On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote: >> On Sun, Jan 15, 2017 at 07:19:03AM +, Winkler, Tomas wrote: >> > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version >> > > only for SPT >> > > and newer

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote: > On Sun, Jan 15, 2017 at 07:19:03AM +, Winkler, Tomas wrote: > > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only > > > for SPT > > > and newer > > > > > > On Sat, Jan 14, 2017 at 08:27:31PM

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote: > On Sun, Jan 15, 2017 at 07:19:03AM +, Winkler, Tomas wrote: > > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only > > > for SPT > > > and newer > > > > > > On Sat, Jan 14, 2017 at 08:27:31PM

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Sun, Jan 15, 2017 at 07:19:03AM +, Winkler, Tomas wrote: > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only > > for SPT > > and newer > > > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > > > Dear Greg, > > > > > > > > > On 2017-01-13 14:00,

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Sun, Jan 15, 2017 at 07:19:03AM +, Winkler, Tomas wrote: > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only > > for SPT > > and newer > > > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > > > Dear Greg, > > > > > > > > > On 2017-01-13 14:00,

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for > SPT > and newer > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > > Dear Greg, > > > > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote: > > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for > SPT > and newer > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > > Dear Greg, > > > > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote: > > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > Dear Greg, > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote: > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: > > > > On 01/11/17 15:12, Winkler, Tomas wrote: > > > > > > > > > On 01/11/17 10:24, Winkler, Tomas

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote: > Dear Greg, > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote: > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: > > > > On 01/11/17 15:12, Winkler, Tomas wrote: > > > > > > > > > On 01/11/17 10:24, Winkler, Tomas

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Dear Greg, On 2017-01-13 14:00, Greg Kroah-Hartman wrote: On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: On 01/11/17 15:12, Winkler, Tomas wrote: > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote:

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Dear Greg, On 2017-01-13 14:00, Greg Kroah-Hartman wrote: On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: On 01/11/17 15:12, Winkler, Tomas wrote: > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote:

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: > Dear Tomas, > > > On 01/11/17 15:12, Winkler, Tomas wrote: > > > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > > > > > > On older platforms

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote: > Dear Tomas, > > > On 01/11/17 15:12, Winkler, Tomas wrote: > > > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > > > > > > On older platforms

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> On 01/11/17 15:12, Winkler, Tomas wrote: > > >>> On 01/11/17 10:24, Winkler, Tomas wrote: > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > >> On older platforms the command should be just ignored by the > >> firmware but some older platforms misbehave so

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> On 01/11/17 15:12, Winkler, Tomas wrote: > > >>> On 01/11/17 10:24, Winkler, Tomas wrote: > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > >> On older platforms the command should be just ignored by the > >> firmware but some older platforms misbehave so

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Dear Tomas, On 01/11/17 15:12, Winkler, Tomas wrote: On 01/11/17 10:24, Winkler, Tomas wrote: On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: On older platforms the command should be just ignored by the firmware but some older platforms misbehave so it's safer to send the

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Dear Tomas, On 01/11/17 15:12, Winkler, Tomas wrote: On 01/11/17 10:24, Winkler, Tomas wrote: On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: On older platforms the command should be just ignored by the firmware but some older platforms misbehave so it's safer to send the

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> > Dear Tomas, > > > > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > >> > > >> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > >>> On older platforms the command should be just ignored by the > > >>> firmware but some older platforms misbehave so it's safer to send > > >>>

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> > Dear Tomas, > > > > > > On 01/11/17 10:24, Winkler, Tomas wrote: > > >> > > >> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > >>> On older platforms the command should be just ignored by the > > >>> firmware but some older platforms misbehave so it's safer to send > > >>>

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> Dear Tomas, > > > On 01/11/17 10:24, Winkler, Tomas wrote: > >> > >> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > >>> On older platforms the command should be just ignored by the > >>> firmware but some older platforms misbehave so it's safer to send > >>> the command only

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> Dear Tomas, > > > On 01/11/17 10:24, Winkler, Tomas wrote: > >> > >> On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > >>> On older platforms the command should be just ignored by the > >>> firmware but some older platforms misbehave so it's safer to send > >>> the command only

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Dear Tomas, On 01/11/17 10:24, Winkler, Tomas wrote: On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: On older platforms the command should be just ignored by the firmware but some older platforms misbehave so it's safer to send the command only if required. Thanks! This

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Dear Tomas, On 01/11/17 10:24, Winkler, Tomas wrote: On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: On older platforms the command should be just ignored by the firmware but some older platforms misbehave so it's safer to send the command only if required. Thanks! This

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > On older platforms the command should be just ignored by the firmware > > but some older platforms misbehave so it's safer to send the command > > only if required. > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad

RE: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

> > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > > On older platforms the command should be just ignored by the firmware > > but some older platforms misbehave so it's safer to send the command > > only if required. > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > On older platforms the command should be just ignored by the firmware > but some older platforms misbehave so it's safer to send the command > only if required. Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s). Jan

Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote: > On older platforms the command should be just ignored by the firmware > but some older platforms misbehave so it's safer to send the command > only if required. Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s). Jan

[char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

From: Alexander Usyskin Sending OS version for support of TPM2_ChangeEPS() is required only for SPT FW (HMB version 2.0) and newer. On older platforms the command should be just ignored by the firmware but some older platforms misbehave so it's safer to send the

[char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

From: Alexander Usyskin Sending OS version for support of TPM2_ChangeEPS() is required only for SPT FW (HMB version 2.0) and newer. On older platforms the command should be just ignored by the firmware but some older platforms misbehave so it's safer to send the command only if required.