Re: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-28 Thread Changman Lee
@vger.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net > > Subject: Re: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to > > prevent accessing invalid > > inode > > > > Hi Chao, > > > > I agree it's correct unlock_new_inode should be lo

RE: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-28 Thread Chao Yu
TCH] f2fs: reposition unlock_new_inode to prevent > accessing invalid > inode > > Hi Chao, > > I agree it's correct unlock_new_inode should be located after make_bad_inode. > > About this scenario, > I think we should check some condition if this could be occured; I think t

RE: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-28 Thread Chao Yu
unlock_new_inode to prevent accessing invalid inode Hi Chao, I agree it's correct unlock_new_inode should be located after make_bad_inode. About this scenario, I think we should check some condition if this could be occured; I think this condition is the almost impossible but which can happen

Re: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-28 Thread Changman Lee
...@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode Hi Chao, I agree it's correct unlock_new_inode should be located after make_bad_inode. About this scenario, I think we should check some condition if this could

Re: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-27 Thread Changman Lee
Hi Chao, I agree it's correct unlock_new_inode should be located after make_bad_inode. About this scenario, I think we should check some condition if this could be occured; A inode allocated newly could be victim by gc thread. Then, f2fs_iget called by Thread A have to fail because we handled it

Re: [f2fs-dev] [PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-27 Thread Changman Lee
Hi Chao, I agree it's correct unlock_new_inode should be located after make_bad_inode. About this scenario, I think we should check some condition if this could be occured; A inode allocated newly could be victim by gc thread. Then, f2fs_iget called by Thread A have to fail because we handled it

[f2fs-dev][PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-26 Thread Chao Yu
As the race condition on the inode cache, following scenario can appear: [Thread a] [Thread b] ->f2fs_mkdir ->f2fs_add_link ->__f2fs_add_link

[f2fs-dev][PATCH] f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-08-26 Thread Chao Yu
As the race condition on the inode cache, following scenario can appear: [Thread a] [Thread b] -f2fs_mkdir -f2fs_add_link -__f2fs_add_link