Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-25 Thread Changman Lee
Hi Simon, Thanks very much for your interest. It becomes more clear due to your explanation. Regards, Changman On Tue, Nov 25, 2014 at 08:05:23PM +0100, Simon Baatz wrote: > Hi Changman, > > On Mon, Nov 24, 2014 at 11:46:46AM +0900, Changman Lee wrote: > > Hi Simon, > > Thanks for your

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-25 Thread Simon Baatz
Hi Changman, On Mon, Nov 24, 2014 at 11:46:46AM +0900, Changman Lee wrote: > Hi Simon, > Thanks for your explanation kindly. > > On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: > > Hi Changman, Jaegeuk, > > > > On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: > > > On

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-25 Thread Simon Baatz
Hi Changman, On Mon, Nov 24, 2014 at 11:46:46AM +0900, Changman Lee wrote: Hi Simon, Thanks for your explanation kindly. On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: Hi Changman, Jaegeuk, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: On Wed, Nov 19,

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-25 Thread Changman Lee
Hi Simon, Thanks very much for your interest. It becomes more clear due to your explanation. Regards, Changman On Tue, Nov 25, 2014 at 08:05:23PM +0100, Simon Baatz wrote: Hi Changman, On Mon, Nov 24, 2014 at 11:46:46AM +0900, Changman Lee wrote: Hi Simon, Thanks for your explanation

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Jaegeuk Kim
On Mon, Nov 24, 2014 at 11:46:46AM +0900, Changman Lee wrote: > Hi Simon, > Thanks for your explanation kindly. > > On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: > > Hi Changman, Jaegeuk, > > > > On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: > > > On Wed, Nov 19,

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Jaegeuk Kim
On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: > Hi Changman, Jaegeuk, Hi Simon, > > On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: > > On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: > > > On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: >

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Changman Lee
Hi Simon, Thanks for your explanation kindly. On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: > Hi Changman, Jaegeuk, > > On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: > > On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: > > > On Thu, Nov 20, 2014 at

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Simon Baatz
Hi Changman, Jaegeuk, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: > On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: > > On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: > > > Hi Jaegeuk, > > > > > > We should call flush_dcache_page before kunmap

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Simon Baatz
Hi Changman, Jaegeuk, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: Hi Jaegeuk, We should call flush_dcache_page before kunmap because the

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Changman Lee
Hi Simon, Thanks for your explanation kindly. On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: Hi Changman, Jaegeuk, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: On Thu, Nov 20, 2014 at 03:04:10PM

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Jaegeuk Kim
On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: Hi Changman, Jaegeuk, Hi Simon, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: Hi

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-23 Thread Jaegeuk Kim
On Mon, Nov 24, 2014 at 11:46:46AM +0900, Changman Lee wrote: Hi Simon, Thanks for your explanation kindly. On Sun, Nov 23, 2014 at 11:08:54AM +0100, Simon Baatz wrote: Hi Changman, Jaegeuk, On Thu, Nov 20, 2014 at 05:47:29PM +0900, Changman Lee wrote: On Wed, Nov 19, 2014 at

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-20 Thread Changman Lee
On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: > On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: > > Hi Jaegeuk, > > > > We should call flush_dcache_page before kunmap because the purpose of the > > cache flush is to address aliasing problem related to virtual

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-20 Thread Changman Lee
On Wed, Nov 19, 2014 at 10:45:33PM -0800, Jaegeuk Kim wrote: On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: Hi Jaegeuk, We should call flush_dcache_page before kunmap because the purpose of the cache flush is to address aliasing problem related to virtual address. Oh,

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Jaegeuk Kim
On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: > Hi Jaegeuk, > > We should call flush_dcache_page before kunmap because the purpose of the > cache flush is to address aliasing problem related to virtual address. Oh, I just followed zero_user_segments below. static inline void

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Changman Lee
Hi Jaegeuk, We should call flush_dcache_page before kunmap because the purpose of the cache flush is to address aliasing problem related to virtual address. On Wed, Nov 19, 2014 at 02:35:08PM -0800, Jaegeuk Kim wrote: > Whenever f2fs updates mapped pages, it needs to call flush_dcache_page. >

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Changman Lee
Hi Jaegeuk, We should call flush_dcache_page before kunmap because the purpose of the cache flush is to address aliasing problem related to virtual address. On Wed, Nov 19, 2014 at 02:35:08PM -0800, Jaegeuk Kim wrote: Whenever f2fs updates mapped pages, it needs to call flush_dcache_page.

Re: [f2fs-dev] [PATCH 1/3] f2fs: call flush_dcache_page when the page was updated

2014-11-19 Thread Jaegeuk Kim
On Thu, Nov 20, 2014 at 03:04:10PM +0900, Changman Lee wrote: Hi Jaegeuk, We should call flush_dcache_page before kunmap because the purpose of the cache flush is to address aliasing problem related to virtual address. Oh, I just followed zero_user_segments below. static inline void