Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-08 Thread Jaegeuk Kim
On Sat, Feb 07, 2015 at 05:57:46PM +0200, Leon Romanovsky wrote: > Hi Jaegeuk, > > > + /* for batched trimming */ > > + int trim_sections; /* # of sections to trim */ > I would like to suggest to declare trim_sections variable as an > unsigned int and not int,

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-08 Thread Jaegeuk Kim
On Sat, Feb 07, 2015 at 05:57:46PM +0200, Leon Romanovsky wrote: Hi Jaegeuk, + /* for batched trimming */ + int trim_sections; /* # of sections to trim */ I would like to suggest to declare trim_sections variable as an unsigned int and not int, since it

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-07 Thread Leon Romanovsky
Hi Jaegeuk, > + /* for batched trimming */ > + int trim_sections; /* # of sections to trim */ I would like to suggest to declare trim_sections variable as an unsigned int and not int, since it can't be negative by definition. What do you think about it? -- To

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-07 Thread Leon Romanovsky
Hi Jaegeuk, + /* for batched trimming */ + int trim_sections; /* # of sections to trim */ I would like to suggest to declare trim_sections variable as an unsigned int and not int, since it can't be negative by definition. What do you think about it? -- To

RE: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-06 Thread Chao Yu
; Subject: Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim > > Hi Chao, > > Something like this? > > Change log from v3: > o align to section size > > This patch introduces a batched trimming feature, which submits split discard > commands. >

RE: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-06 Thread Chao Yu
5/5 v4] f2fs: introduce a batched trim Hi Chao, Something like this? Change log from v3: o align to section size This patch introduces a batched trimming feature, which submits split discard commands. This is to avoid long latency due to huge trim commands. If fstrim was triggered

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-05 Thread Jaegeuk Kim
Hi Chao, Something like this? Change log from v3: o align to section size This patch introduces a batched trimming feature, which submits split discard commands. This is to avoid long latency due to huge trim commands. If fstrim was triggered ranging from 0 to the end of device, we should

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-05 Thread Jaegeuk Kim
Hi Chao, Something like this? Change log from v3: o align to section size This patch introduces a batched trimming feature, which submits split discard commands. This is to avoid long latency due to huge trim commands. If fstrim was triggered ranging from 0 to the end of device, we should