Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Chao Yu
On 2021/2/2 17:07, Daeho Jeong wrote: If I understand it correctly, the only thing I have to do now is remove "nocheckpoint_merge" now. Am I correct? :) For this patch, Yup. :) Thanks, 2021년 2월 2일 (화) 오후 5:30, Chao Yu 님이 작성: On 2021/2/2 16:02, Daeho Jeong wrote: I chose the same step wit

Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Daeho Jeong
If I understand it correctly, the only thing I have to do now is remove "nocheckpoint_merge" now. Am I correct? :) 2021년 2월 2일 (화) 오후 5:30, Chao Yu 님이 작성: > > On 2021/2/2 16:02, Daeho Jeong wrote: > > I chose the same step with "flush_merge", because it doesn't have > > "noflush_merge". > > Oh, "n

Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Chao Yu
On 2021/2/2 16:02, Daeho Jeong wrote: I chose the same step with "flush_merge", because it doesn't have "noflush_merge". Oh, "noxxx" option was added only when we set the option by default in default_options(), when user want to disable the default option, it needs to use "noxxx" option, and th

Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Daeho Jeong
I chose the same step with "flush_merge", because it doesn't have "noflush_merge". Do you think we need that for both, "noflush_merge" and "nocheckpoint_merge"? I thought we needed to give some time to make this be turned on by default. It might be a little radical. :) What do you think? 2021년 2

Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-01 Thread Chao Yu
On 2021/2/2 13:18, Daeho Jeong wrote: From: Daeho Jeong As checkpoint=merge comes in, mount option setting related to checkpoint had been mixed up and it became hard to understand. So, I separated this option from "checkpoint=" and made another mount option "checkpoint_merge" for this. Signed-

Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-01 Thread Jaegeuk Kim
On 02/02, Daeho Jeong wrote: > From: Daeho Jeong > > As checkpoint=merge comes in, mount option setting related to checkpoint > had been mixed up and it became hard to understand. So, I separated > this option from "checkpoint=" and made another mount option > "checkpoint_merge" for this. Thanks