Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-12-02 Thread Chao Yu
On 2020/12/3 14:08, Jaegeuk Kim wrote: On 12/02, Jaegeuk Kim wrote: On 12/03, Chao Yu wrote: Jaegeuk, not sure, is it too late to merge this cleanup into original patch? Let me merge this on top of tree. Thanks. :) I integrated this into the original patch since I had to revise this commit.

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-12-02 Thread Jaegeuk Kim
On 12/02, Jaegeuk Kim wrote: > On 12/03, Chao Yu wrote: > > Jaegeuk, not sure, is it too late to merge this cleanup into original patch? > > Let me merge this on top of tree. Thanks. :) I integrated this into the original patch since I had to revise this commit. :( ("f2fs: avoid race condition fo

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-12-02 Thread Jaegeuk Kim
On 12/03, Chao Yu wrote: > Jaegeuk, not sure, is it too late to merge this cleanup into original patch? Let me merge this on top of tree. Thanks. :) > > From a5c63ec58e0cda6eb5d186b46942eea46422b7a9 Mon Sep 17 00:00:00 2001 > From: Chao Yu > Date: Thu, 3 Dec 2020 10:04:26 +0800 > Subject: [PATC

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-12-02 Thread Daeho Jeong
Oh, by the control logic changed in the previous patch, we don't need to use f2fs_is_compress_algorithm_valid() anymore. Looks good~ 2020년 12월 3일 (목) 오전 11:49, Chao Yu 님이 작성: > > Jaegeuk, not sure, is it too late to merge this cleanup into original patch? > > From a5c63ec58e0cda6eb5d186b46942eea4

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-12-02 Thread Chao Yu
Jaegeuk, not sure, is it too late to merge this cleanup into original patch? From a5c63ec58e0cda6eb5d186b46942eea46422b7a9 Mon Sep 17 00:00:00 2001 From: Chao Yu Date: Thu, 3 Dec 2020 10:04:26 +0800 Subject: [PATCH] f2fs: remove f2fs_is_compress_algorithm_valid() for cleanup No logic changes.

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-11-01 Thread Chao Yu
On 2020/11/2 7:42, Daeho Jeong wrote: Oh, even if those are patchset, then I have to send just changed ones? There is no strict constraint condition, and I'm okay with both ways, however, I prefer the way just sending changed one because IMO it can help to save review time on those unchanged pa

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-11-01 Thread Daeho Jeong
Oh, even if those are patchset, then I have to send just changed ones? Got it. 2020년 10월 30일 (금) 오후 3:13, Chao Yu 님이 작성: > > Daeho, > > If there is no change, we are used to not resend the patch with updated > version. > > Thanks, > > On 2020/10/30 12:10, Daeho Jeong wrote: > > From: Daeho Jeong

Re: [f2fs-dev] [PATCH v7 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl

2020-10-29 Thread Chao Yu
Daeho, If there is no change, we are used to not resend the patch with updated version. Thanks, On 2020/10/30 12:10, Daeho Jeong wrote: From: Daeho Jeong Added a new F2FS_IOC_SET_COMPRESS_OPTION ioctl to change file compression option of a file. struct f2fs_comp_option { u8 algorithm;