From: Oleg Nesterov
event_id_read() has no reason to kmalloc "struct trace_seq"
(more than PAGE_SIZE!), it can use a small buffer instead.
Note: "if (*ppos) return 0" looks strange and even wrong,
simple_read_from_buffer() handles ppos != 0 case corrrectly.
And it seems that almost every user
From: Oleg Nesterov o...@redhat.com
event_id_read() has no reason to kmalloc struct trace_seq
(more than PAGE_SIZE!), it can use a small buffer instead.
Note: if (*ppos) return 0 looks strange and even wrong,
simple_read_from_buffer() handles ppos != 0 case corrrectly.
And it seems that almost
2 matches
Mail list logo