Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread arvindY
On Friday 27 April 2018 06:32 PM, Alex Elder wrote: On 04/27/2018 07:50 AM, Arvind Yadav wrote: On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked through

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Alex Elder
On 04/27/2018 07:50 AM, Arvind Yadav wrote: > > > On Friday 27 April 2018 05:47 PM, Alex Elder wrote: >> On 04/27/2018 05:52 AM, Arvind Yadav wrote: >>> Replace the manual validity checks for the GPIO with the >>> gpio_is_valid(). >> I haven't looked through the code paths very closely, but I >>

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Arvind Yadav
On Friday 27 April 2018 05:47 PM, Alex Elder wrote: On 04/27/2018 05:52 AM, Arvind Yadav wrote: Replace the manual validity checks for the GPIO with the gpio_is_valid(). I haven't looked through the code paths very closely, but I think that get_named_gpio() might return -EPROBE_DEFER, which w

Re: [greybus-dev] [PATCH] staging: greybus: Use gpio_is_valid()

2018-04-27 Thread Alex Elder
On 04/27/2018 05:52 AM, Arvind Yadav wrote: > Replace the manual validity checks for the GPIO with the > gpio_is_valid(). I haven't looked through the code paths very closely, but I think that get_named_gpio() might return -EPROBE_DEFER, which would be something we want to pass to the caller. So