Re: [kernel-hardening][PATCH v3 1/3] arm: mm: dump: make page table dumping reusable

2017-12-06 Thread Kees Cook
On Wed, Dec 6, 2017 at 1:45 AM, Jinbum Park wrote: >>> +#ifndef __ASM_PTDUMP_H >>> +#define __ASM_PTDUMP_H >>> + >>> +#ifdef CONFIG_ARM_PTDUMP_CORE >> >> Is this #ifdef needed? I think this file is only included in dump.c >> and ptdump_debugfs.c, both of which are only built when >> CONFIG_ARM_PTD

Re: [kernel-hardening][PATCH v3 1/3] arm: mm: dump: make page table dumping reusable

2017-12-06 Thread Jinbum Park
>> +#ifndef __ASM_PTDUMP_H >> +#define __ASM_PTDUMP_H >> + >> +#ifdef CONFIG_ARM_PTDUMP_CORE > > Is this #ifdef needed? I think this file is only included in dump.c > and ptdump_debugfs.c, both of which are only built when > CONFIG_ARM_PTDUMP_CORE is defined. Looking at next patch in this patch-se

Re: [kernel-hardening][PATCH v3 1/3] arm: mm: dump: make page table dumping reusable

2017-12-05 Thread Kees Cook
On Mon, Dec 4, 2017 at 6:25 AM, Jinbum Park wrote: > This patch refactors the arm page table dumping code, > so multiple tables may be registered with the framework. > > This patch refers below commits of arm64. > (4674fdb9f149 ("arm64: mm: dump: make page table dumping reusable")) > (4ddb9bf83349

[kernel-hardening][PATCH v3 1/3] arm: mm: dump: make page table dumping reusable

2017-12-04 Thread Jinbum Park
This patch refactors the arm page table dumping code, so multiple tables may be registered with the framework. This patch refers below commits of arm64. (4674fdb9f149 ("arm64: mm: dump: make page table dumping reusable")) (4ddb9bf83349 ("arm64: dump: Make ptdump debugfs a separate option")) Signe