Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

2007-08-27 Thread Johannes Berg
On Mon, 2007-08-27 at 13:06 +0200, Rafael J. Wysocki wrote: > Well, I don't like the "weak symbols" stuff, but I have managed to limit the > number of additional #ifdefs in snapshot.c to just one. > > The "generic" patch is now the following: Fine with me, I was just throwing out ideas anyway

Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

2007-08-27 Thread Rafael J. Wysocki
On Saturday, 25 August 2007 21:13, Johannes Berg wrote: > On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote: > > > The preferred way of doing this is via Kconfig, please. ie: add a > > CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig. > > > It would be better to do something like this in

Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

2007-08-27 Thread Johannes Berg
On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote: > The preferred way of doing this is via Kconfig, please. ie: add a > CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig. > It would be better to do something like this in (say) suspend.h: > > #ifdef CONFIG_HIBERNATION_HEADER > extern int

Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

2007-08-27 Thread Johannes Berg
On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote: The preferred way of doing this is via Kconfig, please. ie: add a CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig. It would be better to do something like this in (say) suspend.h: #ifdef CONFIG_HIBERNATION_HEADER extern int

Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

2007-08-27 Thread Rafael J. Wysocki
On Saturday, 25 August 2007 21:13, Johannes Berg wrote: On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote: The preferred way of doing this is via Kconfig, please. ie: add a CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig. It would be better to do something like this in (say)

Re: [linux-pm] Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

2007-08-27 Thread Johannes Berg
On Mon, 2007-08-27 at 13:06 +0200, Rafael J. Wysocki wrote: Well, I don't like the weak symbols stuff, but I have managed to limit the number of additional #ifdefs in snapshot.c to just one. The generic patch is now the following: Fine with me, I was just throwing out ideas anyway :)