Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Oct 26, 2007 at 11:11:22AM +0800, Dave Young wrote: > > On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > > Anyway the sysfs_dirent_exist is useful for extern use, How about add > > > > and export this function? Greg, If you agree, I

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Greg KH
On Fri, Oct 26, 2007 at 11:11:22AM +0800, Dave Young wrote: > On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > Anyway the sysfs_dirent_exist is useful for extern use, How about add > > > and export this function? Greg, If you agree, I would send it as > > > another patch. > > > > What would

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Oct 26, 2007 at 10:01:49AM +0800, Dave Young wrote: > > On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: > > > > On 10/19/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > > >On

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Greg KH
On Fri, Oct 26, 2007 at 10:01:49AM +0800, Dave Young wrote: > On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > > On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: > > > On 10/19/07, Greg KH <[EMAIL PROTECTED]> wrote: > > > >On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: > >

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/26/07, Greg KH <[EMAIL PROTECTED]> wrote: > On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: > > On 10/19/07, Greg KH <[EMAIL PROTECTED]> wrote: > > >On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: > > >> On Tue, 16 Oct 2007, Matthew Dharm wrote: > > >> > > >> > On

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Greg KH
On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: > On 10/19/07, Greg KH <[EMAIL PROTECTED]> wrote: > >On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: > >> On Tue, 16 Oct 2007, Matthew Dharm wrote: > >> > >> > On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: > >> >

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/19/07, Greg KH <[EMAIL PROTECTED]> wrote: >On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: >> On Tue, 16 Oct 2007, Matthew Dharm wrote: >> >> > On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: >> > > On Tue, 16 Oct 2007, Matthew Dharm wrote: >> > > >> > > > I haven't

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/19/07, Greg KH [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Greg KH
On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: On 10/19/07, Greg KH [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: On 10/19/07, Greg KH [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: On Tue, Oct 16, 2007 at

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Greg KH
On Fri, Oct 26, 2007 at 10:01:49AM +0800, Dave Young wrote: On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: On 10/19/07, Greg KH [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: On Tue, 16

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: On Fri, Oct 26, 2007 at 10:01:49AM +0800, Dave Young wrote: On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: On Thu, Oct 25, 2007 at 05:06:59PM +0800, Dave Young wrote: On 10/19/07, Greg KH [EMAIL PROTECTED] wrote: On Wed, Oct 17, 2007 at

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Greg KH
On Fri, Oct 26, 2007 at 11:11:22AM +0800, Dave Young wrote: On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: Anyway the sysfs_dirent_exist is useful for extern use, How about add and export this function? Greg, If you agree, I would send it as another patch. What would need that

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-25 Thread Dave Young
On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: On Fri, Oct 26, 2007 at 11:11:22AM +0800, Dave Young wrote: On 10/26/07, Greg KH [EMAIL PROTECTED] wrote: Anyway the sysfs_dirent_exist is useful for extern use, How about add and export this function? Greg, If you agree, I would send it as

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-18 Thread Greg KH
On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: > > > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > > > > > I haven't looked at this code at all, but neither approach feels

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-18 Thread Greg KH
On Wed, Oct 17, 2007 at 10:48:52AM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at all, but neither approach feels right to

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-17 Thread Dave Young
On 10/17/07, Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: > > > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > > > > > I haven't looked at this code at all, but neither approach feels right > >

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-17 Thread Alan Stern
On Tue, 16 Oct 2007, Matthew Dharm wrote: > On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: > > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > > > I haven't looked at this code at all, but neither approach feels right to > > > me. > > > > > > How does this work at all? Even if you

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-17 Thread Dave Young
On 10/17/07, Alan Stern [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at all, but neither approach feels right to me.

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-17 Thread Alan Stern
On Tue, 16 Oct 2007, Matthew Dharm wrote: On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at all, but neither approach feels right to me. How does this work at all? Even if you load a driver

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Dave Young
>On 10/17/07, Matthew Dharm <[EMAIL PROTECTED]> wrote: > On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: > > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > > > I haven't looked at this code at all, but neither approach feels right to > > > me. > > > > > > How does this work at all?

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Matthew Dharm
On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: > On Tue, 16 Oct 2007, Matthew Dharm wrote: > > > I haven't looked at this code at all, but neither approach feels right to > > me. > > > > How does this work at all? Even if you load a driver later, wouldn't it > > call

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Alan Stern
On Tue, 16 Oct 2007, Matthew Dharm wrote: > I haven't looked at this code at all, but neither approach feels right to > me. > > How does this work at all? Even if you load a driver later, wouldn't it > call usb_set_interface(), which would call usb_create_sysfs_intf_files() > and hit the same

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Matthew Dharm
On Tue, Oct 16, 2007 at 10:55:54AM -0400, Alan Stern wrote: > On Tue, 16 Oct 2007, Dave Young wrote: > > > > I finally duplicated this on one of my machines here at boot time, with > > > USB built into the kernel. I'll work tomorrow on tracking this down > > > further... > > Hi, > > I add some

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Alan Stern
On Tue, 16 Oct 2007, Dave Young wrote: > > I finally duplicated this on one of my machines here at boot time, with > > USB built into the kernel. I'll work tomorrow on tracking this down > > further... > Hi, > I add some printk messages, dump_stack and some others, here is the > dmesg dump with

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Alan Stern
On Tue, 16 Oct 2007, Dave Young wrote: I finally duplicated this on one of my machines here at boot time, with USB built into the kernel. I'll work tomorrow on tracking this down further... Hi, I add some printk messages, dump_stack and some others, here is the dmesg dump with debug

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Matthew Dharm
On Tue, Oct 16, 2007 at 10:55:54AM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Dave Young wrote: I finally duplicated this on one of my machines here at boot time, with USB built into the kernel. I'll work tomorrow on tracking this down further... Hi, I add some printk messages,

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Alan Stern
On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at all, but neither approach feels right to me. How does this work at all? Even if you load a driver later, wouldn't it call usb_set_interface(), which would call usb_create_sysfs_intf_files() and hit the same issue?

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Matthew Dharm
On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at all, but neither approach feels right to me. How does this work at all? Even if you load a driver later, wouldn't it call usb_set_interface(), which

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-16 Thread Dave Young
On 10/17/07, Matthew Dharm [EMAIL PROTECTED] wrote: On Tue, Oct 16, 2007 at 02:04:43PM -0400, Alan Stern wrote: On Tue, 16 Oct 2007, Matthew Dharm wrote: I haven't looked at this code at all, but neither approach feels right to me. How does this work at all? Even if you load a

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-15 Thread Dave Young
>On 10/16/07, Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Oct 15, 2007 at 02:38:25PM -0400, Alan Stern wrote: > > On Mon, 15 Oct 2007, Dave Young wrote: > > > > > On 10/14/07, Borislav Petkov <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > > > > > > i get the following warning on yesterday's git

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-15 Thread Greg KH
On Mon, Oct 15, 2007 at 02:38:25PM -0400, Alan Stern wrote: > On Mon, 15 Oct 2007, Dave Young wrote: > > > On 10/14/07, Borislav Petkov <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > > > i get the following warning on yesterday's git tree > > > (v2.6.23-2840-g752097c): > > > > > > Oct 14 09:07:15

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-15 Thread Alan Stern
On Mon, 15 Oct 2007, Dave Young wrote: > On 10/14/07, Borislav Petkov <[EMAIL PROTECTED]> wrote: > > Hi, > > > > i get the following warning on yesterday's git tree (v2.6.23-2840-g752097c): > > > > Oct 14 09:07:15 zmei kernel: [ 49.368030] sysfs: duplicate filename > > 'bInterfaceNumber' can

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-15 Thread Alan Stern
On Mon, 15 Oct 2007, Dave Young wrote: On 10/14/07, Borislav Petkov [EMAIL PROTECTED] wrote: Hi, i get the following warning on yesterday's git tree (v2.6.23-2840-g752097c): Oct 14 09:07:15 zmei kernel: [ 49.368030] sysfs: duplicate filename 'bInterfaceNumber' can not be created

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-15 Thread Greg KH
On Mon, Oct 15, 2007 at 02:38:25PM -0400, Alan Stern wrote: On Mon, 15 Oct 2007, Dave Young wrote: On 10/14/07, Borislav Petkov [EMAIL PROTECTED] wrote: Hi, i get the following warning on yesterday's git tree (v2.6.23-2840-g752097c): Oct 14 09:07:15 zmei kernel: [

Re: [linux-usb-devel] usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-15 Thread Dave Young
On 10/16/07, Greg KH [EMAIL PROTECTED] wrote: On Mon, Oct 15, 2007 at 02:38:25PM -0400, Alan Stern wrote: On Mon, 15 Oct 2007, Dave Young wrote: On 10/14/07, Borislav Petkov [EMAIL PROTECTED] wrote: Hi, i get the following warning on yesterday's git tree