Re: [lustre-devel] LIBCFS_ALLOC

2015-07-03 Thread Dilger, Andreas
On 2015/07/02, 4:25 PM, "Simmons, James A." wrote: > >>> >Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have >>>even >>> >a tiny sliver of RAM isn't going to work. It's easier to use >>> >libcfs_kvzalloc() everywhere, but it's probably the wrong thing. >>> >>> The original

Re: [lustre-devel] LIBCFS_ALLOC

2015-07-03 Thread Dilger, Andreas
On 2015/07/02, 4:25 PM, Simmons, James A. simmon...@ornl.gov wrote: Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have even a tiny sliver of RAM isn't going to work. It's easier to use libcfs_kvzalloc() everywhere, but it's probably the wrong thing. The original reason we

RE: [lustre-devel] LIBCFS_ALLOC

2015-07-02 Thread Simmons, James A.
>> >Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have even >> >a tiny sliver of RAM isn't going to work. It's easier to use >> >libcfs_kvzalloc() everywhere, but it's probably the wrong thing. >> >> The original reason we have the vmalloc water mark wasn't so much the >> issue

RE: [lustre-devel] LIBCFS_ALLOC

2015-07-02 Thread Simmons, James A.
Yeah. You're right. Doing a vmalloc() when kmalloc() doesn't have even a tiny sliver of RAM isn't going to work. It's easier to use libcfs_kvzalloc() everywhere, but it's probably the wrong thing. The original reason we have the vmalloc water mark wasn't so much the issue of memory

Re: [lustre-devel] LIBCFS_ALLOC

2015-06-30 Thread Dilger, Andreas
On 2015/06/28, 12:52 AM, "Julia Lawall" wrote: >It is not clear that all of the uses of LIBCFS_ALLOC really risk needing >vmalloc. For example: > >lnet/klnds/socklnd/socklnd.c, function ksocknal_accept: > >ksock_connreq_t *cr; >... >LIBCFS_ALLOC(cr, sizeof(*cr)); > >The definition of

Re: [lustre-devel] LIBCFS_ALLOC

2015-06-30 Thread Dilger, Andreas
On 2015/06/28, 12:52 AM, Julia Lawall julia.law...@lip6.fr wrote: It is not clear that all of the uses of LIBCFS_ALLOC really risk needing vmalloc. For example: lnet/klnds/socklnd/socklnd.c, function ksocknal_accept: ksock_connreq_t *cr; ... LIBCFS_ALLOC(cr, sizeof(*cr)); The definition of