Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-03 Thread Marcin Wojtas
Graeme, 2018-01-03 12:16 GMT+01:00 : > On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: >> > * Modify way of obtaining interrupts - with ACPI they are resources >> > bound to struct platform_device and it's not possible to obtain >> > them directly from

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-03 Thread Marcin Wojtas
Graeme, 2018-01-03 12:16 GMT+01:00 : > On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: >> > * Modify way of obtaining interrupts - with ACPI they are resources >> > bound to struct platform_device and it's not possible to obtain >> > them directly from the child node. Hence a

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-03 Thread graeme . gregory
On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: > > * Modify way of obtaining interrupts - with ACPI they are resources > > bound to struct platform_device and it's not possible to obtain > > them directly from the child node. Hence a formula is used, depending > > on the

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-03 Thread graeme . gregory
On Sun, Dec 31, 2017 at 08:23:54PM +0100, Andrew Lunn wrote: > > * Modify way of obtaining interrupts - with ACPI they are resources > > bound to struct platform_device and it's not possible to obtain > > them directly from the child node. Hence a formula is used, depending > > on the

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Florian Fainelli
On January 2, 2018 7:05:35 AM PST, Marcin Wojtas wrote: >2018-01-02 15:08 GMT+01:00 Andrew Lunn : >>> Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is >more >>> a discussion for a MDIO bus / ACPI patchset, but we either find a >way >>> to use

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Florian Fainelli
On January 2, 2018 7:05:35 AM PST, Marcin Wojtas wrote: >2018-01-02 15:08 GMT+01:00 Andrew Lunn : >>> Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is >more >>> a discussion for a MDIO bus / ACPI patchset, but we either find a >way >>> to use IRQs with ACPI obtained from child

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Marcin Wojtas
2018-01-02 15:08 GMT+01:00 Andrew Lunn : >> Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is more >> a discussion for a MDIO bus / ACPI patchset, but we either find a way >> to use IRQs with ACPI obtained from child nodes or for this world the >> functionality will

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Marcin Wojtas
2018-01-02 15:08 GMT+01:00 Andrew Lunn : >> Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is more >> a discussion for a MDIO bus / ACPI patchset, but we either find a way >> to use IRQs with ACPI obtained from child nodes or for this world the >> functionality will be limited (at

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Andrew Lunn
> Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is more > a discussion for a MDIO bus / ACPI patchset, but we either find a way > to use IRQs with ACPI obtained from child nodes or for this world the > functionality will be limited (at least for the beginning). Hi Marcin What i

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Andrew Lunn
> Indeed in of_mdio_bus_register_phy, there is of_irq_get. This is more > a discussion for a MDIO bus / ACPI patchset, but we either find a way > to use IRQs with ACPI obtained from child nodes or for this world the > functionality will be limited (at least for the beginning). Hi Marcin What i

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Marcin Wojtas
Hi Andrew, 2018-01-02 14:33 GMT+01:00 Andrew Lunn : >> Apart from the phylink's SFP support that may require in-band >> management, it's an alternative to the normal PHY handling. Once MDIO >> bus + PHYs are supported for ACPI, phylib support will be used instead >> of the IRQs,

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Marcin Wojtas
Hi Andrew, 2018-01-02 14:33 GMT+01:00 Andrew Lunn : >> Apart from the phylink's SFP support that may require in-band >> management, it's an alternative to the normal PHY handling. Once MDIO >> bus + PHYs are supported for ACPI, phylib support will be used instead >> of the IRQs, so there should

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Andrew Lunn
> Apart from the phylink's SFP support that may require in-band > management, it's an alternative to the normal PHY handling. Once MDIO > bus + PHYs are supported for ACPI, phylib support will be used instead > of the IRQs, so there should be no problem here. Hi Marcin However, phylib and

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-02 Thread Andrew Lunn
> Apart from the phylink's SFP support that may require in-band > management, it's an alternative to the normal PHY handling. Once MDIO > bus + PHYs are supported for ACPI, phylib support will be used instead > of the IRQs, so there should be no problem here. Hi Marcin However, phylib and

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-01 Thread Marcin Wojtas
HI Andrew, 2017-12-31 20:23 GMT+01:00 Andrew Lunn : >> * Modify way of obtaining interrupts - with ACPI they are resources >> bound to struct platform_device and it's not possible to obtain >> them directly from the child node. Hence a formula is used, depending >> on the

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2018-01-01 Thread Marcin Wojtas
HI Andrew, 2017-12-31 20:23 GMT+01:00 Andrew Lunn : >> * Modify way of obtaining interrupts - with ACPI they are resources >> bound to struct platform_device and it's not possible to obtain >> them directly from the child node. Hence a formula is used, depending >> on the port_id and number

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2017-12-31 Thread Andrew Lunn
> * Modify way of obtaining interrupts - with ACPI they are resources > bound to struct platform_device and it's not possible to obtain > them directly from the child node. Hence a formula is used, depending > on the port_id and number of possible CPUs. Hi Marcin I know nothing about ACPI.

Re: [net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2017-12-31 Thread Andrew Lunn
> * Modify way of obtaining interrupts - with ACPI they are resources > bound to struct platform_device and it's not possible to obtain > them directly from the child node. Hence a formula is used, depending > on the port_id and number of possible CPUs. Hi Marcin I know nothing about ACPI.

[net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2017-12-31 Thread Marcin Wojtas
This patch introduces an alternative way of obtaining resources - via ACPI tables provided by firmware. Enabling coexistence with the DT support, in addition to the OF_*->device_*/fwnode_* API replacement, required following steps to be taken: * Add mvpp2_acpi_match table * Omit clock

[net-next: PATCH v2 5/5] net: mvpp2: enable ACPI support in the driver

2017-12-31 Thread Marcin Wojtas
This patch introduces an alternative way of obtaining resources - via ACPI tables provided by firmware. Enabling coexistence with the DT support, in addition to the OF_*->device_*/fwnode_* API replacement, required following steps to be taken: * Add mvpp2_acpi_match table * Omit clock