Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 15:51:25 -0500 David Dillow <[EMAIL PROTECTED]> wrote: > > On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: > > As for a better fix, I'm not sure. > > Here's a better way than the strncmp. If this meets everyone's approval, > then I can roll up a proper commit.

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread Roland Dreier
> +if (scsi_is_srp_rport(dev)) > +srp_rport_del(dev_to_rport(dev)); This has the ring of truth to me as the right fix, although I certainly don't know the details of this code... Fujita-san? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: > As for a better fix, I'm not sure. Here's a better way than the strncmp. If this meets everyone's approval, then I can roll up a proper commit. diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c index

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 17:30 +0900, FUJITA Tomonori wrote: > On Wed, 02 Jan 2008 09:51:38 -0800 > Roland Dreier <[EMAIL PROTECTED]> wrote: > > > > > Can you try this? > > > > > > That patched oopsed in scsi_remove_host(), but reversing the order has > > > survived over 500

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 17:30 +0900, FUJITA Tomonori wrote: On Wed, 02 Jan 2008 09:51:38 -0800 Roland Dreier [EMAIL PROTECTED] wrote: Can you try this? That patched oopsed in scsi_remove_host(), but reversing the order has survived over 500 insert/probe/remove cycles.

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread David Dillow
On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: As for a better fix, I'm not sure. Here's a better way than the strncmp. If this meets everyone's approval, then I can roll up a proper commit. diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c index

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread Roland Dreier
+if (scsi_is_srp_rport(dev)) +srp_rport_del(dev_to_rport(dev)); This has the ring of truth to me as the right fix, although I certainly don't know the details of this code... Fujita-san? - R. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2008-01-03 Thread FUJITA Tomonori
On Thu, 03 Jan 2008 15:51:25 -0500 David Dillow [EMAIL PROTECTED] wrote: On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote: As for a better fix, I'm not sure. Here's a better way than the strncmp. If this meets everyone's approval, then I can roll up a proper commit. Thanks! I

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-22 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Fri, 21 Dec 2007 17:18 -0500: > On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: > > I'm getting the following oops when doing the following commands: > > > > modprobe ib_srp > > > > rmmod ib_srp > > modprobe ib_srp > > > > > > I'm going to try and track down

Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-22 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Fri, 21 Dec 2007 17:18 -0500: On Fri, 2007-12-21 at 16:52 -0500, David Dillow wrote: I'm getting the following oops when doing the following commands: modprobe ib_srp add targets(s) to ib_srp using sysfs rmmod ib_srp modprobe ib_srp OOPS I'm going to