Re: [PATCH][MTHCA] fix sparc build WAS: Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-20 Thread David S. Miller
On Wed, 20 Apr 2005 17:37:11 -0700 Tom Duffy <[EMAIL PROTECTED]> wrote: > This breaks building on sparc64: ... > This is ugly, but fixes the build. Perhaps sparc needs > pgprot_noncached() to be a noop? No, it should actually do something, like so: include/asm-sparc64/pgtable.h:

[PATCH][MTHCA] fix sparc build WAS: Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-20 Thread Tom Duffy
On Mon, 2005-04-04 at 15:09 -0700, Roland Dreier wrote: > @@ -574,6 +836,22 @@ > return 0; > } > > +static int mthca_mmap_uar(struct ib_ucontext *context, > + struct vm_area_struct *vma) > +{ > + if (vma->vm_end - vma->vm_start != PAGE_SIZE) > +

[PATCH][MTHCA] fix sparc build WAS: Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-20 Thread Tom Duffy
On Mon, 2005-04-04 at 15:09 -0700, Roland Dreier wrote: @@ -574,6 +836,22 @@ return 0; } +static int mthca_mmap_uar(struct ib_ucontext *context, + struct vm_area_struct *vma) +{ + if (vma-vm_end - vma-vm_start != PAGE_SIZE) + return

Re: [PATCH][MTHCA] fix sparc build WAS: Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-20 Thread David S. Miller
On Wed, 20 Apr 2005 17:37:11 -0700 Tom Duffy [EMAIL PROTECTED] wrote: This breaks building on sparc64: ... This is ugly, but fixes the build. Perhaps sparc needs pgprot_noncached() to be a noop? No, it should actually do something, like so: include/asm-sparc64/pgtable.h:

Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-04 Thread Tom Duffy
On Mon, 2005-04-04 at 15:09 -0700, Roland Dreier wrote: > --- linux-export.orig/drivers/infiniband/hw/mthca/mthca_dev.h 2005-04-04 > 14:57:12.254750421 -0700 > +++ linux-export/drivers/infiniband/hw/mthca/mthca_dev.h 2005-04-04 > 14:58:12.411669307 -0700 > @@ -49,14 +49,6 @@ > #define

Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-04 Thread Roland Dreier
Tom> Now, you are really gonna hate me for asking you to put this Tom> in as you probably did not want to include this in the patch Tom> to lkml. Tom> So, maybe Grant was right ;-) Oh well, I didn't read the patches over carefully enough. Fortunately it was just my "for review"

Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-04 Thread Roland Dreier
Tom Now, you are really gonna hate me for asking you to put this Tom in as you probably did not want to include this in the patch Tom to lkml. Tom So, maybe Grant was right ;-) Oh well, I didn't read the patches over carefully enough. Fortunately it was just my for review

Re: [openib-general] [PATCH][RFC][3/4] IB: userspace verbs mthca changes

2005-04-04 Thread Tom Duffy
On Mon, 2005-04-04 at 15:09 -0700, Roland Dreier wrote: --- linux-export.orig/drivers/infiniband/hw/mthca/mthca_dev.h 2005-04-04 14:57:12.254750421 -0700 +++ linux-export/drivers/infiniband/hw/mthca/mthca_dev.h 2005-04-04 14:58:12.411669307 -0700 @@ -49,14 +49,6 @@ #define