Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-12 Thread Mark Brown
On Wed, Jul 11, 2012 at 09:36:02AM +0300, Dan Carpenter wrote: > Smatch complains about this. I don't have a way to test this, but it > does look like we should unlock on error here. > > Signed-off-by: Dan Carpenter Acke-dby: Mark Brown signature.asc Description: Digital signature

Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-12 Thread Mark Brown
On Wed, Jul 11, 2012 at 09:36:02AM +0300, Dan Carpenter wrote: Smatch complains about this. I don't have a way to test this, but it does look like we should unlock on error here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acke-dby: Mark Brown broo...@opensource.wolfsonmicro.com

Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Chanwoo Choi
Hi Dan, On 07/11/2012 03:36 PM, Dan Carpenter wrote: > Smatch complains about this. I don't have a way to test this, but it > does look like we should unlock on error here. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c >

[patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Dan Carpenter
Smatch complains about this. I don't have a way to test this, but it does look like we should unlock on error here. Signed-off-by: Dan Carpenter diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index b068bc9..4782884 100644 --- a/drivers/extcon/extcon-arizona.c

[patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Dan Carpenter
Smatch complains about this. I don't have a way to test this, but it does look like we should unlock on error here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index b068bc9..4782884 100644 ---

Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()

2012-07-11 Thread Chanwoo Choi
Hi Dan, On 07/11/2012 03:36 PM, Dan Carpenter wrote: Smatch complains about this. I don't have a way to test this, but it does look like we should unlock on error here. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/extcon/extcon-arizona.c