Re: [patch] NULL pointer check for vma->vm_mm

2008-02-01 Thread Kenichi Okuyama
Dear Andrew, Sorry that it took very long before I could reply. 2008/2/1, Andrew Morton <[EMAIL PROTECTED]>: > On Fri, 1 Feb 2008 17:24:17 +0900 "Kenichi Okuyama" <[EMAIL PROTECTED]> wrote: > > > First of all, thank you for looking at the patch. > > > > I do agree that if mm is NULL, system will c

Re: [patch] NULL pointer check for vma->vm_mm

2008-02-01 Thread Andrew Morton
On Fri, 1 Feb 2008 17:24:17 +0900 "Kenichi Okuyama" <[EMAIL PROTECTED]> wrote: > First of all, thank you for looking at the patch. > > I do agree that if mm is NULL, system will call Oops anyway. > However, since it's oops, it does not stop the system, nor call kdump. That would be a huge bug in

Re: [patch] NULL pointer check for vma->vm_mm

2008-02-01 Thread Kenichi Okuyama
Dear Andrew, all, First of all, thank you for looking at the patch. I do agree that if mm is NULL, system will call Oops anyway. However, since it's oops, it does not stop the system, nor call kdump. By calling BUG_ON(), it'll gives us chance of calling kdump at the first chance. Since this is

Re: [patch] NULL pointer check for vma->vm_mm

2008-01-31 Thread Andrew Morton
On Fri, 1 Feb 2008 16:39:07 +0900 "Kenichi Okuyama" <[EMAIL PROTECTED]> wrote: > Dear all, > > I was looking at the ./mm/rmap.c .. I found that, in function > "page_referenced_one()", >struct mm_struct *mm = vma->vm_mm; > was being refererred without NULL check. > > Though I do agree that th

[patch] NULL pointer check for vma->vm_mm

2008-01-31 Thread Kenichi Okuyama
Dear all, I was looking at the ./mm/rmap.c .. I found that, in function "page_referenced_one()", struct mm_struct *mm = vma->vm_mm; was being refererred without NULL check. Though I do agree that this works for most of the cases, I thought it is better to add BUG_ON() for case of mm being NULL