Re: [patch] acenic driver update

2000-11-15 Thread Pekka Pietikainen
On Wed, Nov 15, 2000 at 05:31:27AM +0100, Jes Sorensen wrote: > > "Val" == Val Henson <[EMAIL PROTECTED]> writes: > Val> Jes, I just downloaded the 0.48 acenic driver and it still has a > Val> reproducible null dereference bug. Anyone can oops their machine > Val> by doing: > > Bugger I

Re: [patch] acenic driver update

2000-11-15 Thread Pekka Pietikainen
On Wed, Nov 15, 2000 at 05:31:27AM +0100, Jes Sorensen wrote: "Val" == Val Henson [EMAIL PROTECTED] writes: Val Jes, I just downloaded the 0.48 acenic driver and it still has a Val reproducible null dereference bug. Anyone can oops their machine Val by doing: Bugger I think I lost your

Re: [patch] acenic driver update

2000-11-14 Thread Jes Sorensen
> "Val" == Val Henson <[EMAIL PROTECTED]> writes: Val> Jes, I just downloaded the 0.48 acenic driver and it still has a Val> reproducible null dereference bug. Anyone can oops their machine Val> by doing: Bugger I think I lost your patch in the noise. Sorry about that, it'll be in the next

Re: [patch] acenic driver update

2000-11-14 Thread kuznet
Hello! > - netif_stop_queue() was called in post softnet mode when entering > start_xmit() which was unnecessary. Now it is only set when the > queue is full. Jes, it is not necessary since linux-2.0 or so... All the difference with softnet is that you need not _test_ tbusy on entry.

Re: [patch] acenic driver update

2000-11-14 Thread kuznet
Hello! - netif_stop_queue() was called in post softnet mode when entering start_xmit() which was unnecessary. Now it is only set when the queue is full. Jes, it is not necessary since linux-2.0 or so... All the difference with softnet is that you need not _test_ tbusy on entry. That's

Re: [patch] acenic driver update

2000-11-13 Thread Jeff Garzik
You would think it would be easier to maintain a separate 2.2.x and 2.4.x version of acenic.c at this point :) Jes Sorensen wrote: > @@ -2307,14 +2337,10 @@ > u32 idx, flagsize; > > /* > -* ARGH, there is just no pretty way to do this > +* This only happens with

[patch] acenic driver update

2000-11-13 Thread Jes Sorensen
Hi Linus Here is a patch to bring the acenic driver update with the latest fixes. It fixes the following issues: - Driver wasn't being initialized when compiled statically into the kernel. - set_macaddr() set the address incorrectly on little endian machines. - netif_stop_queue() was called

[patch] acenic driver update

2000-11-13 Thread Jes Sorensen
Hi Linus Here is a patch to bring the acenic driver update with the latest fixes. It fixes the following issues: - Driver wasn't being initialized when compiled statically into the kernel. - set_macaddr() set the address incorrectly on little endian machines. - netif_stop_queue() was called

Re: [patch] acenic driver update

2000-11-13 Thread Jeff Garzik
You would think it would be easier to maintain a separate 2.2.x and 2.4.x version of acenic.c at this point :) Jes Sorensen wrote: @@ -2307,14 +2337,10 @@ u32 idx, flagsize; /* -* ARGH, there is just no pretty way to do this +* This only happens with