Ming Lei writes:
> The following change should be put into blk_mq_init_hctx() too.
>
> hctx->flags = set->flags & ~BLK_MQ_F_TAG_SHARED;
>
> and the idea is that we always figure out the shared flag in
> following blk_mq_update_tag_set_depth().
OK, this is the part I was missing from your ea
On Thu, Oct 29, 2015 at 11:18 PM, Jeff Moyer wrote:
> Ming Lei writes:
>
>> Looks we should have cleared the TAG_SHARED flag during
>> blk_mq_init_hctx() and just let blk_mq_update_tag_set_depth()
>> deal with that, then the race can be avoided.
>
> The whole point of the patch set is to propagat
Ming Lei writes:
> Looks we should have cleared the TAG_SHARED flag during
> blk_mq_init_hctx() and just let blk_mq_update_tag_set_depth()
> deal with that, then the race can be avoided.
The whole point of the patch set is to propagate the flag up to the tag
set so that we can avoid iterating al
On Thu, Oct 29, 2015 at 10:20 PM, Jeff Moyer wrote:
> Hi Ming,
>
> Thanks for taking a look.
>
> Ming Lei writes:
>
>> On Fri, Oct 23, 2015 at 10:57 PM, Jeff Moyer wrote:
>>> Hi,
>>>
>>> Zhangqing Luo reported long boot times on a system with thousands of
>>> LUNs when scsi-mq was enabled. He n
Hi Ming,
Thanks for taking a look.
Ming Lei writes:
> On Fri, Oct 23, 2015 at 10:57 PM, Jeff Moyer wrote:
>> Hi,
>>
>> Zhangqing Luo reported long boot times on a system with thousands of
>> LUNs when scsi-mq was enabled. He narrowed the problem down to
>> blk_mq_add_queue_tag_set, where ever
On Fri, Oct 23, 2015 at 10:57 PM, Jeff Moyer wrote:
> Hi,
>
> Zhangqing Luo reported long boot times on a system with thousands of
> LUNs when scsi-mq was enabled. He narrowed the problem down to
> blk_mq_add_queue_tag_set, where every queue is frozen in order to set
> the BLK_MQ_F_TAG_SHARED fla
Hi,
Does anyone have time to look into the patch? I've tested, it works
/Thanks.
On Friday, October 23, 2015 10:57 PM, Jeff Moyer wrote:
Hi,
Zhangqing Luo reported long boot times on a system with thousands of
LUNs when scsi-mq was enabled. He narrowed the problem down to
blk_mq_add_queu
Hi,
Zhangqing Luo reported long boot times on a system with thousands of
LUNs when scsi-mq was enabled. He narrowed the problem down to
blk_mq_add_queue_tag_set, where every queue is frozen in order to set
the BLK_MQ_F_TAG_SHARED flag. Each added device will freeze all queues
added before it in
8 matches
Mail list logo
