Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()

2017-01-26 Thread Serge Semin
On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter wrote: > "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with > kfree() is a double free. In fact, we don't need to free it at all. > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR

Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()

2017-01-26 Thread Serge Semin
On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter wrote: > "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with > kfree() is a double free. In fact, we don't need to free it at all. > > Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") > Signed-off-by: Dan

[patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()

2017-01-26 Thread Dan Carpenter
"pdev->ee_file" was allocated with devm_kmalloc() so freeing it with kfree() is a double free. In fact, we don't need to free it at all. Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") Signed-off-by: Dan Carpenter diff --git

[patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()

2017-01-26 Thread Dan Carpenter
"pdev->ee_file" was allocated with devm_kmalloc() so freeing it with kfree() is a double free. In fact, we don't need to free it at all. Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver") Signed-off-by: Dan Carpenter diff --git a/drivers/misc/eeprom/idt_89hpesx.c