Re: [patch] fix NULL pointer deference in ALPS

2005-03-07 Thread Benoit Boissinot
On Mon, Mar 07, 2005 at 04:06:33PM +0200, Alexey Dobriyan wrote: > On Monday 07 March 2005 14:24, Benoit Boissinot wrote: > > > alps_get_model returns a pointer or NULL in case of errors, so we need to > > check for the results being NULL, not negative. > > 2.6.11-bk2: int alps_get_model(struct

Re: [patch] fix NULL pointer deference in ALPS

2005-03-07 Thread Vojtech Pavlik
On Mon, Mar 07, 2005 at 02:10:02PM +0100, Vojtech Pavlik wrote: > On Mon, Mar 07, 2005 at 01:24:32PM +0100, Benoit Boissinot wrote: > > I get a NULL pointer deference in with alps while suspending. > > > > The following patch fixes it: alps_get_model returns a pointer or > > NULL in case of error

Re: [patch] fix NULL pointer deference in ALPS

2005-03-07 Thread Vojtech Pavlik
On Mon, Mar 07, 2005 at 01:24:32PM +0100, Benoit Boissinot wrote: > I get a NULL pointer deference in with alps while suspending. > > The following patch fixes it: alps_get_model returns a pointer or > NULL in case of errors, so we need to check for the results being NULL, > not negative. > > Sin

Re: [patch] fix NULL pointer deference in ALPS

2005-03-07 Thread Alexey Dobriyan
On Monday 07 March 2005 14:24, Benoit Boissinot wrote: > alps_get_model returns a pointer or NULL in case of errors, so we need to > check for the results being NULL, not negative. 2.6.11-bk2: int alps_get_model(struct psmouse *psmouse) takes 1 argument, returns -1 on error 2.6.11-mm

[patch] fix NULL pointer deference in ALPS

2005-03-07 Thread Benoit Boissinot
I get a NULL pointer deference in with alps while suspending. The following patch fixes it: alps_get_model returns a pointer or NULL in case of errors, so we need to check for the results being NULL, not negative. Since it is trivial, it is maybe a candidate for 2.6.11.2. It does not apply to -m