Anton Altaparmakov writes:
[...]
>
> mm/filemap.c::file_buffered_write():
>
> - It calls fault_in_pages_readable() which is completely bogus if
> @nr_segs > 1. It needs to be replaced by a to be written
> "fault_in_pages_readable_iovec()".
Which will be only marginally less bogus,
On Fri, 2005-04-22 at 19:10 +0400, Nikita Danilov wrote:
> Anton Altaparmakov writes:
> > mm/filemap.c::file_buffered_write():
> >
> > - It calls fault_in_pages_readable() which is completely bogus if
> > @nr_segs > 1. It needs to be replaced by a to be written
> >
On Fri, 2005-04-22 at 19:10 +0400, Nikita Danilov wrote:
Anton Altaparmakov writes:
mm/filemap.c::file_buffered_write():
- It calls fault_in_pages_readable() which is completely bogus if
@nr_segs 1. It needs to be replaced by a to be written
fault_in_pages_readable_iovec().
Anton Altaparmakov writes:
[...]
mm/filemap.c::file_buffered_write():
- It calls fault_in_pages_readable() which is completely bogus if
@nr_segs 1. It needs to be replaced by a to be written
fault_in_pages_readable_iovec().
Which will be only marginally less bogus, because
On Thu, 2005-04-21 at 17:20 +1000, Nick Piggin wrote:
> On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote:
> > And one more thing...
> >
> > On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
> > > On Thu, 21 Apr 2005, Nick Piggin wrote:
> > > > ... I somehow didn't send it to
On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote:
> And one more thing...
>
> On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
> > On Thu, 21 Apr 2005, Nick Piggin wrote:
> > > ... I somehow didn't send it to Andrew last time.
> > >
> > > Fix a race where
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
> Any reason why you left the goto out? It would be IMO much cleaner to
> remove the label "out" altogether and replace the single "goto out" with a
> "break" (which is fine since the goto happens inside the for loop
> immediately
And one more thing...
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
> On Thu, 21 Apr 2005, Nick Piggin wrote:
> > ... I somehow didn't send it to Andrew last time.
> >
> > Fix a race where __block_prepare_write can leak out an in-flight
> > read against a bh if get_block returns
Hi,
On Thu, 21 Apr 2005, Nick Piggin wrote:
> ... I somehow didn't send it to Andrew last time.
>
> Fix a race where __block_prepare_write can leak out an in-flight
> read against a bh if get_block returns an error. This can lead to
> the page becoming unlocked while the buffer is locked and the
... I somehow didn't send it to Andrew last time.
--
SUSE Labs, Novell Inc.
Fix a race where __block_prepare_write can leak out an in-flight
read against a bh if get_block returns an error. This can lead to
the page becoming unlocked while the buffer is locked and the read
still in flight.
Questions? Comments?
--
SUSE Labs, Novell Inc.
Fix a race where __block_prepare_write can leak out an in-flight
read against a bh if get_block returns an error. This can lead to
the page becoming unlocked while the buffer is locked and the read
still in flight. __mpage_writepage BUGs on this
Questions? Comments?
--
SUSE Labs, Novell Inc.
Fix a race where __block_prepare_write can leak out an in-flight
read against a bh if get_block returns an error. This can lead to
the page becoming unlocked while the buffer is locked and the read
still in flight. __mpage_writepage BUGs on this
... I somehow didn't send it to Andrew last time.
--
SUSE Labs, Novell Inc.
Fix a race where __block_prepare_write can leak out an in-flight
read against a bh if get_block returns an error. This can lead to
the page becoming unlocked while the buffer is locked and the read
still in flight.
Hi,
On Thu, 21 Apr 2005, Nick Piggin wrote:
... I somehow didn't send it to Andrew last time.
Fix a race where __block_prepare_write can leak out an in-flight
read against a bh if get_block returns an error. This can lead to
the page becoming unlocked while the buffer is locked and the read
And one more thing...
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
On Thu, 21 Apr 2005, Nick Piggin wrote:
... I somehow didn't send it to Andrew last time.
Fix a race where __block_prepare_write can leak out an in-flight
read against a bh if get_block returns an error.
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
Any reason why you left the goto out? It would be IMO much cleaner to
remove the label out altogether and replace the single goto out with a
break (which is fine since the goto happens inside the for loop
immediately after which
On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote:
And one more thing...
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
On Thu, 21 Apr 2005, Nick Piggin wrote:
... I somehow didn't send it to Andrew last time.
Fix a race where __block_prepare_write can leak
On Thu, 2005-04-21 at 17:20 +1000, Nick Piggin wrote:
On Thu, 2005-04-21 at 08:10 +0100, Anton Altaparmakov wrote:
And one more thing...
On Thu, 2005-04-21 at 08:01 +0100, Anton Altaparmakov wrote:
On Thu, 21 Apr 2005, Nick Piggin wrote:
... I somehow didn't send it to Andrew last
18 matches
Mail list logo
