Re: [patch] mm, slab: initialize object alignment on cache creation

2014-09-24 Thread Christoph Lameter
On Tue, 23 Sep 2014, David Rientjes wrote: > Previous to commit 4590685546a3 ("mm/sl[aou]b: Common alignment code") > which introduced this issue. Ah. Ok. I see and approve. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [patch] mm, slab: initialize object alignment on cache creation

2014-09-24 Thread Christoph Lameter
On Tue, 23 Sep 2014, David Rientjes wrote: Previous to commit 4590685546a3 (mm/sl[aou]b: Common alignment code) which introduced this issue. Ah. Ok. I see and approve. Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [patch] mm, slab: initialize object alignment on cache creation

2014-09-23 Thread David Rientjes
On Tue, 23 Sep 2014, Christoph Lameter wrote: > > The proper alignment defaults to BYTES_PER_WORD and can be overridden by > > SLAB_RED_ZONE or the alignment specified by the caller. > > Where does it default to BYTES_PER_WORD in __kmem_cache_create? > Previous to commit 4590685546a3

Re: [patch] mm, slab: initialize object alignment on cache creation

2014-09-23 Thread Christoph Lameter
On Tue, 23 Sep 2014, David Rientjes wrote: > The proper alignment defaults to BYTES_PER_WORD and can be overridden by > SLAB_RED_ZONE or the alignment specified by the caller. Where does it default to BYTES_PER_WORD in __kmem_cache_create? -- To unsubscribe from this list: send the line

[patch] mm, slab: initialize object alignment on cache creation

2014-09-23 Thread David Rientjes
Since 4590685546a3 ("mm/sl[aou]b: Common alignment code"), the "ralign" automatic variable in __kmem_cache_create() may be used as uninitialized. The proper alignment defaults to BYTES_PER_WORD and can be overridden by SLAB_RED_ZONE or the alignment specified by the caller. This fixes

[patch] mm, slab: initialize object alignment on cache creation

2014-09-23 Thread David Rientjes
Since 4590685546a3 (mm/sl[aou]b: Common alignment code), the ralign automatic variable in __kmem_cache_create() may be used as uninitialized. The proper alignment defaults to BYTES_PER_WORD and can be overridden by SLAB_RED_ZONE or the alignment specified by the caller. This fixes

Re: [patch] mm, slab: initialize object alignment on cache creation

2014-09-23 Thread Christoph Lameter
On Tue, 23 Sep 2014, David Rientjes wrote: The proper alignment defaults to BYTES_PER_WORD and can be overridden by SLAB_RED_ZONE or the alignment specified by the caller. Where does it default to BYTES_PER_WORD in __kmem_cache_create? -- To unsubscribe from this list: send the line

Re: [patch] mm, slab: initialize object alignment on cache creation

2014-09-23 Thread David Rientjes
On Tue, 23 Sep 2014, Christoph Lameter wrote: The proper alignment defaults to BYTES_PER_WORD and can be overridden by SLAB_RED_ZONE or the alignment specified by the caller. Where does it default to BYTES_PER_WORD in __kmem_cache_create? Previous to commit 4590685546a3 (mm/sl[aou]b: