Re: [patch] mm: clean up zone flags

2014-09-05 Thread Mel Gorman
On Tue, Sep 02, 2014 at 06:26:53PM -0400, Johannes Weiner wrote: > From 2420ad16df0634e073ad327f0f72472d9b03762b Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Tue, 2 Sep 2014 10:14:36 -0400 > Subject: [patch] mm: clean up zone flags > > Page reclaim tests zon

Re: [patch] mm: clean up zone flags

2014-09-05 Thread Mel Gorman
On Tue, Sep 02, 2014 at 06:26:53PM -0400, Johannes Weiner wrote: From 2420ad16df0634e073ad327f0f72472d9b03762b Mon Sep 17 00:00:00 2001 From: Johannes Weiner han...@cmpxchg.org Date: Tue, 2 Sep 2014 10:14:36 -0400 Subject: [patch] mm: clean up zone flags Page reclaim tests

Re: [patch] mm: clean up zone flags

2014-09-02 Thread Johannes Weiner
Acked-by: David Rientjes > > since this un-obscurification is most welcome. Yikes, thanks for catching those and acking. Updated patch: --- >From 2420ad16df0634e073ad327f0f72472d9b03762b Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Tue, 2 Sep 2014 10:14:36 -0400 Sub

Re: [patch] mm: clean up zone flags

2014-09-02 Thread David Rientjes
On Tue, 2 Sep 2014, Johannes Weiner wrote: > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 318df7051850..48bf12ef6620 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -521,13 +521,13 @@ struct zone { > atomic_long_t

[patch] mm: clean up zone flags

2014-09-02 Thread Johannes Weiner
Page reclaim tests zone_is_reclaim_dirty(), but the site that actually sets this state does zone_set_flag(zone, ZONE_TAIL_LRU_DIRTY), sending the reader through layers indirection just to track down a simple bit. Remove all zone flag wrappers and just use bitops against zone->flags directly.

[patch] mm: clean up zone flags

2014-09-02 Thread Johannes Weiner
Page reclaim tests zone_is_reclaim_dirty(), but the site that actually sets this state does zone_set_flag(zone, ZONE_TAIL_LRU_DIRTY), sending the reader through layers indirection just to track down a simple bit. Remove all zone flag wrappers and just use bitops against zone-flags directly. It's

Re: [patch] mm: clean up zone flags

2014-09-02 Thread David Rientjes
On Tue, 2 Sep 2014, Johannes Weiner wrote: diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 318df7051850..48bf12ef6620 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -521,13 +521,13 @@ struct zone { atomic_long_t

Re: [patch] mm: clean up zone flags

2014-09-02 Thread Johannes Weiner
...@google.com since this un-obscurification is most welcome. Yikes, thanks for catching those and acking. Updated patch: --- From 2420ad16df0634e073ad327f0f72472d9b03762b Mon Sep 17 00:00:00 2001 From: Johannes Weiner han...@cmpxchg.org Date: Tue, 2 Sep 2014 10:14:36 -0400 Subject: [patch] mm: clean up