Re: [patch] net: make ndev->irq signed for error handling

2013-11-08 Thread Mugunthan V N
On Friday 08 November 2013 02:11 PM, Dan Carpenter wrote: > On Thu, Nov 07, 2013 at 10:03:19PM +0530, Mugunthan V N wrote: >> On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: >>> On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 01:18 PM,

Re: [patch] net: make ndev->irq signed for error handling

2013-11-08 Thread Dan Carpenter
On Thu, Nov 07, 2013 at 10:03:19PM +0530, Mugunthan V N wrote: > On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: > > On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: > >> On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: > >>> There is a bug in cpsw_probe()

Re: [patch] net: make ndev-irq signed for error handling

2013-11-08 Thread Dan Carpenter
On Thu, Nov 07, 2013 at 10:03:19PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: There is a bug in cpsw_probe() where we do:

Re: [patch] net: make ndev-irq signed for error handling

2013-11-08 Thread Mugunthan V N
On Friday 08 November 2013 02:11 PM, Dan Carpenter wrote: On Thu, Nov 07, 2013 at 10:03:19PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 01:18 PM, Dan

Re: [patch] net: make ndev->irq signed for error handling

2013-11-07 Thread David Miller
From: Dan Carpenter Date: Thu, 7 Nov 2013 10:48:49 +0300 > There is a bug in cpsw_probe() where we do: > > ndev->irq = platform_get_irq(pdev, 0); > if (ndev->irq < 0) { > > The problem is that "ndev->irq" is unsigned so the error handling > doesn't work. I have changed it to a

Re: [patch] net: make ndev->irq signed for error handling

2013-11-07 Thread Mugunthan V N
On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: > On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: >> On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: >>> There is a bug in cpsw_probe() where we do: >>> >>> ndev->irq = platform_get_irq(pdev, 0); >>> if

Re: [patch] net: make ndev->irq signed for error handling

2013-11-07 Thread Dan Carpenter
On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: > On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: > > There is a bug in cpsw_probe() where we do: > > > > ndev->irq = platform_get_irq(pdev, 0); > > if (ndev->irq < 0) { > > > > The problem is that "ndev->irq" is

Re: [patch] net: make ndev->irq signed for error handling

2013-11-07 Thread Mugunthan V N
On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: > There is a bug in cpsw_probe() where we do: > > ndev->irq = platform_get_irq(pdev, 0); > if (ndev->irq < 0) { > > The problem is that "ndev->irq" is unsigned so the error handling > doesn't work. I have changed it to a

Re: [patch] net: make ndev-irq signed for error handling

2013-11-07 Thread Mugunthan V N
On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: There is a bug in cpsw_probe() where we do: ndev-irq = platform_get_irq(pdev, 0); if (ndev-irq 0) { The problem is that ndev-irq is unsigned so the error handling doesn't work. I have changed it to a regular int.

Re: [patch] net: make ndev-irq signed for error handling

2013-11-07 Thread Dan Carpenter
On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: There is a bug in cpsw_probe() where we do: ndev-irq = platform_get_irq(pdev, 0); if (ndev-irq 0) { The problem is that ndev-irq is unsigned so the error

Re: [patch] net: make ndev-irq signed for error handling

2013-11-07 Thread Mugunthan V N
On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote: On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote: On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote: There is a bug in cpsw_probe() where we do: ndev-irq = platform_get_irq(pdev, 0); if (ndev-irq 0) {

Re: [patch] net: make ndev-irq signed for error handling

2013-11-07 Thread David Miller
From: Dan Carpenter dan.carpen...@oracle.com Date: Thu, 7 Nov 2013 10:48:49 +0300 There is a bug in cpsw_probe() where we do: ndev-irq = platform_get_irq(pdev, 0); if (ndev-irq 0) { The problem is that ndev-irq is unsigned so the error handling doesn't work. I have changed

[patch] net: make ndev->irq signed for error handling

2013-11-06 Thread Dan Carpenter
There is a bug in cpsw_probe() where we do: ndev->irq = platform_get_irq(pdev, 0); if (ndev->irq < 0) { The problem is that "ndev->irq" is unsigned so the error handling doesn't work. I have changed it to a regular int. Signed-off-by: Dan Carpenter diff --git

[patch] net: make ndev-irq signed for error handling

2013-11-06 Thread Dan Carpenter
There is a bug in cpsw_probe() where we do: ndev-irq = platform_get_irq(pdev, 0); if (ndev-irq 0) { The problem is that ndev-irq is unsigned so the error handling doesn't work. I have changed it to a regular int. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff