Re: [patch] new aop loop fix

2007-06-13 Thread Hugh Dickins
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: > Btw: Nick's patches broke LO_CRYPT_XOR mode, It would help him if you could describe how. > but it is ok because > this feature was absolete and not used by anyone, am i right here? I know nothing of this; but so long as its code remains in the

Re: [patch] new aop loop fix

2007-06-13 Thread Dmitriy Monakhov
On 14:36 Срд 13 Июн , Hugh Dickins wrote: > On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: > > > loop.c code itself is not perfect. In fact before Nick's patch > > partial write was't possible. Assumption what write chunks are > > always page aligned is realy weird ( see "index++"

Re: [patch] new aop loop fix

2007-06-13 Thread Hugh Dickins
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: > loop.c code itself is not perfect. In fact before Nick's patch > partial write was't possible. Assumption what write chunks are > always page aligned is realy weird ( see "index++" line). > > Signed-off-by: Dmitriy Monakhov <[EMAIL

[patch] new aop loop fix

2007-06-13 Thread Dmitriy Monakhov
loop.c code itself is not perfect. In fact before Nick's patch partial write was't possible. Assumption what write chunks are always page aligned is realy weird ( see "index++" line). Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> diff --git a/drivers/block/loop.c

[patch] new aop loop fix

2007-06-13 Thread Dmitriy Monakhov
loop.c code itself is not perfect. In fact before Nick's patch partial write was't possible. Assumption what write chunks are always page aligned is realy weird ( see index++ line). Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] diff --git a/drivers/block/loop.c

Re: [patch] new aop loop fix

2007-06-13 Thread Hugh Dickins
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: loop.c code itself is not perfect. In fact before Nick's patch partial write was't possible. Assumption what write chunks are always page aligned is realy weird ( see index++ line). Signed-off-by: Dmitriy Monakhov [EMAIL

Re: [patch] new aop loop fix

2007-06-13 Thread Dmitriy Monakhov
On 14:36 Срд 13 Июн , Hugh Dickins wrote: On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: loop.c code itself is not perfect. In fact before Nick's patch partial write was't possible. Assumption what write chunks are always page aligned is realy weird ( see index++ line).

Re: [patch] new aop loop fix

2007-06-13 Thread Hugh Dickins
On Wed, 13 Jun 2007, Dmitriy Monakhov wrote: Btw: Nick's patches broke LO_CRYPT_XOR mode, It would help him if you could describe how. but it is ok because this feature was absolete and not used by anyone, am i right here? I know nothing of this; but so long as its code remains in the