Re: [patch] pinctrl: berlin: fix an error code in berlin_pinctrl_probe()

2014-07-04 Thread Linus Walleij
On Wed, Jun 11, 2014 at 10:15 AM, Dan Carpenter wrote: > We are returning success here because PTR_ERR(NULL) is zero. We should > be returning -ENODEV. > > Fixes: 3de68d331c24 ('pinctrl: berlin: add the core pinctrl driver for > Marvell Berlin SoCs') > Signed-off-by: Dan Carpenter Patch appli

Re: [patch] pinctrl: berlin: fix an error code in berlin_pinctrl_probe()

2014-06-11 Thread Sebastian Hesselbarth
On 06/11/2014 10:15 AM, Dan Carpenter wrote: We are returning success here because PTR_ERR(NULL) is zero. We should be returning -ENODEV. Fixes: 3de68d331c24 ('pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs') Signed-off-by: Dan Carpenter Dan, thanks for the fix! Acked

[patch] pinctrl: berlin: fix an error code in berlin_pinctrl_probe()

2014-06-11 Thread Dan Carpenter
We are returning success here because PTR_ERR(NULL) is zero. We should be returning -ENODEV. Fixes: 3de68d331c24 ('pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs') Signed-off-by: Dan Carpenter diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c