revert commit:
commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d
Author: Matthew Wilcox <[EMAIL PROTECTED]>
Date: Tue Sep 25 12:42:04 2007 -0400
[SCSI] Get rid of scsi_cmnd->done
this is a supposed-to-be-cleanup commit, but apparently it causes
regressions:
Bug 9370 -
revert commit:
commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d
Author: Matthew Wilcox [EMAIL PROTECTED]
Date: Tue Sep 25 12:42:04 2007 -0400
[SCSI] Get rid of scsi_cmnd-done
this is a supposed-to-be-cleanup commit, but apparently it causes
regressions:
Bug 9370 -
On Wed, 2008-01-02 at 17:25 +0100, Ingo Molnar wrote:
revert commit:
commit 6f5391c283d7fdcf24bf40786ea79061919d1e1d
Author: Matthew Wilcox [EMAIL PROTECTED]
Date: Tue Sep 25 12:42:04 2007 -0400
[SCSI] Get rid of scsi_cmnd-done
this is a supposed-to-be-cleanup commit,
On Wed, 2 Jan 2008, James Bottomley wrote:
I disagree with this. We only have one reporter of a problem and it
appears to be some type of obscure interaction with pktdvd which no-one
can track down (although it's not really helped by the reporter not
being very responsive).
It's totally
On Wed, Jan 02, 2008 at 11:19:14AM -0800, Linus Torvalds wrote:
It's totally immaterial if we have one reporter or many. The fact is, that
thing has been outstanding for almost two months now. The root cause is
almost certainly known (and Matthew is apparently even aware of it), but
I
On Wed, 2 Jan 2008, Matthew Wilcox wrote:
sd_done and sr_done are called for REQ_TYPE_FS -- if the request comes
in through one of the SG interfaces, we call scsi_setup_blk_pc_cmnd()
which sets the -done callback to scsi_blk_pc_done.
Why do you think that REQ_TYPE_BLOCK_PC has anything to
On Wed, 2008-01-02 at 12:40 -0700, Matthew Wilcox wrote:
On Wed, Jan 02, 2008 at 11:19:14AM -0800, Linus Torvalds wrote:
It's totally immaterial if we have one reporter or many. The fact is, that
thing has been outstanding for almost two months now. The root cause is
almost certainly
On Wed, Jan 02, 2008 at 11:57:10AM -0800, Linus Torvalds wrote:
On Wed, 2 Jan 2008, Matthew Wilcox wrote:
sd_done and sr_done are called for REQ_TYPE_FS -- if the request comes
in through one of the SG interfaces, we call scsi_setup_blk_pc_cmnd()
which sets the -done callback to
On Wed, Jan 02, 2008 at 11:57:10AM -0800, Linus Torvalds wrote:
On Wed, 2 Jan 2008, Matthew Wilcox wrote:
sd_done and sr_done are called for REQ_TYPE_FS -- if the request comes
in through one of the SG interfaces, we call scsi_setup_blk_pc_cmnd()
which sets the -done callback to
On Wed, 2 Jan 2008, James Bottomley wrote:
OK ... I'll revert it. However, I still think it's the wrong course of
action, because as far as my analysis goes, this code is functionally
equivalent to what went before with the exception that we now rely on
the request-cmd_type information in
On Wed, 2 Jan 2008, Christoph Hellwig wrote:
I think you misunderstood Matthew here. REQ_TYPE_BLOCK_PC is indeed
used by any kind of SG_IO or similar passthrough no matter where it
originates. And exactly because REQ_TYPE_BLOCK_PC are entirely passthru
the actual driver (sd, sr or sg) is
On Wed, Jan 02, 2008 at 12:49:32PM -0800, Linus Torvalds wrote:
Maybe it's not that one suspicious test. Maybe it's somethign else. But
that commit was confirmed to break something, almost two months ago. You
guys seem to be in denial, and saying it didn't change anything.
And no, waiting
On Wed, 2008-01-02 at 12:45 -0800, Linus Torvalds wrote:
On Wed, 2 Jan 2008, James Bottomley wrote:
OK ... I'll revert it. However, I still think it's the wrong course of
action, because as far as my analysis goes, this code is functionally
equivalent to what went before with the
On Wed, 2 Jan 2008, James Bottomley wrote:
To say that another way:
the code is functionally equivalent, EXCEPT IT ISN'T, and it's
known to be broken.
wouldn't you say my version is more honest and correct?
No. Just because a bug appears when a particular piece of code
101 - 114 of 114 matches
Mail list logo
