Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-12 Thread Pierre Ossman
On Sat, 12 Jan 2008 08:02:37 -0500 Robin Getz <[EMAIL PROTECTED]> wrote: > > According to the HW folks - it is exactly as Pierre indicated - in theory it > should work, 4-bit MMC requires usage of different set of commands as > compared to 4-bit SD, so it should be just software - although no

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-12 Thread Bryan Wu
On Jan 12, 2008 9:02 PM, Robin Getz <[EMAIL PROTECTED]> wrote: > On Fri 11 Jan 2008 12:52, Robin Getz pondered: > > > On Fri 11 Jan 2008 04:35, Pierre Ossman pondered: > > > On Fri, 11 Jan 2008 04:08:53 -0500 > > > "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > > > > > > On Jan 11, 2008 3:40 AM,

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-12 Thread Robin Getz
On Fri 11 Jan 2008 12:52, Robin Getz pondered: > On Fri 11 Jan 2008 04:35, Pierre Ossman pondered: > > On Fri, 11 Jan 2008 04:08:53 -0500 > > "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > > > > On Jan 11, 2008 3:40 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > > > So it's far more probable

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-12 Thread Robin Getz
On Fri 11 Jan 2008 12:52, Robin Getz pondered: On Fri 11 Jan 2008 04:35, Pierre Ossman pondered: On Fri, 11 Jan 2008 04:08:53 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 11, 2008 3:40 AM, Pierre Ossman [EMAIL PROTECTED] wrote: So it's far more probable that you've

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-12 Thread Bryan Wu
On Jan 12, 2008 9:02 PM, Robin Getz [EMAIL PROTECTED] wrote: On Fri 11 Jan 2008 12:52, Robin Getz pondered: On Fri 11 Jan 2008 04:35, Pierre Ossman pondered: On Fri, 11 Jan 2008 04:08:53 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 11, 2008 3:40 AM, Pierre Ossman [EMAIL

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-12 Thread Pierre Ossman
On Sat, 12 Jan 2008 08:02:37 -0500 Robin Getz [EMAIL PROTECTED] wrote: According to the HW folks - it is exactly as Pierre indicated - in theory it should work, 4-bit MMC requires usage of different set of commands as compared to 4-bit SD, so it should be just software - although no one

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Robin Getz
On Fri 11 Jan 2008 04:35, Pierre Ossman pondered: > On Fri, 11 Jan 2008 04:08:53 -0500 > "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > > On Jan 11, 2008 3:40 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > > So it's far more probable that you've misdiagnosed your error than > this being the

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 18:22:14 +0800 "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > I guess it is for MMC/SD card insert detection. Is it related with the > 4-bit MMC and 4-bit SD? > Actually, there are some issues about the card insert detection on > BF54x SDH. Following is some comments of our

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Bryan Wu
On Jan 11, 2008 6:05 PM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Fri, 11 Jan 2008 04:47:44 -0500 > "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > > Cliff should be able to enumerate the cards he has tested and the > > issues he's run into. i'll see if i cant get more in depth > >

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 04:47:44 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > Cliff should be able to enumerate the cards he has tested and the > issues he's run into. i'll see if i cant get more in depth > information from the hardware guys beyond the documentation on the sdh > already

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Mike Frysinger
On Jan 11, 2008 4:35 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > > On Jan 11, 2008 3:40 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > > So it's far more probable that you've misdiagnosed your error than this > > > being the actual problem. > > >

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 04:08:53 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > On Jan 11, 2008 3:40 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > So it's far more probable that you've misdiagnosed your error than this > > being the actual problem. > > the guys who design the silicon are

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Mike Frysinger
On Jan 11, 2008 3:40 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > We were told this is an hardware design issue, so please help us to > > workaround it in software side with Mike's patch. > > So it's far more probable that you've misdiagnosed your error

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 14:17:01 +0800 "Bryan Wu" <[EMAIL PROTECTED]> wrote: > We were told this is an hardware design issue, so please help us to > workaround it in software side with Mike's patch. I'm afraid that's insufficient motivation for this change. All documentation and real world tests

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 14:17:01 +0800 Bryan Wu [EMAIL PROTECTED] wrote: We were told this is an hardware design issue, so please help us to workaround it in software side with Mike's patch. I'm afraid that's insufficient motivation for this change. All documentation and real world tests say that

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Mike Frysinger
On Jan 11, 2008 3:40 AM, Pierre Ossman [EMAIL PROTECTED] wrote: Bryan Wu [EMAIL PROTECTED] wrote: We were told this is an hardware design issue, so please help us to workaround it in software side with Mike's patch. So it's far more probable that you've misdiagnosed your error than this

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Bryan Wu
On Jan 11, 2008 6:05 PM, Pierre Ossman [EMAIL PROTECTED] wrote: On Fri, 11 Jan 2008 04:47:44 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: Cliff should be able to enumerate the cards he has tested and the issues he's run into. i'll see if i cant get more in depth information from the

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 04:08:53 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 11, 2008 3:40 AM, Pierre Ossman [EMAIL PROTECTED] wrote: So it's far more probable that you've misdiagnosed your error than this being the actual problem. the guys who design the silicon are telling us it

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Mike Frysinger
On Jan 11, 2008 4:35 AM, Pierre Ossman [EMAIL PROTECTED] wrote: Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 11, 2008 3:40 AM, Pierre Ossman [EMAIL PROTECTED] wrote: So it's far more probable that you've misdiagnosed your error than this being the actual problem. the guys who

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 04:47:44 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: Cliff should be able to enumerate the cards he has tested and the issues he's run into. i'll see if i cant get more in depth information from the hardware guys beyond the documentation on the sdh already available in

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Pierre Ossman
On Fri, 11 Jan 2008 18:22:14 +0800 Bryan Wu [EMAIL PROTECTED] wrote: I guess it is for MMC/SD card insert detection. Is it related with the 4-bit MMC and 4-bit SD? Actually, there are some issues about the card insert detection on BF54x SDH. Following is some comments of our bfin-sdh driver

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-11 Thread Robin Getz
On Fri 11 Jan 2008 04:35, Pierre Ossman pondered: On Fri, 11 Jan 2008 04:08:53 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 11, 2008 3:40 AM, Pierre Ossman [EMAIL PROTECTED] wrote: So it's far more probable that you've misdiagnosed your error than this being the actual problem.

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Mike Frysinger
On Jan 11, 2008 1:17 AM, Bryan Wu <[EMAIL PROTECTED]> wrote: > On Jan 10, 2008 7:57 PM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > On Thu, 10 Jan 2008 17:22:55 +0800 > > "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > > > > > > > At page 4-3 of ADSP-BF54x Blackfin(R) Processor Peripheral Hardware > >

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Bryan Wu
On Jan 10, 2008 7:57 PM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Thu, 10 Jan 2008 17:22:55 +0800 > "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > > > > At page 4-3 of ADSP-BF54x Blackfin(R) Processor Peripheral Hardware > > Reference, there is a table which guide us the SDH controller does not >

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Pierre Ossman
On Thu, 10 Jan 2008 17:22:55 +0800 "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > At page 4-3 of ADSP-BF54x Blackfin(R) Processor Peripheral Hardware > Reference, there is a table which guide us the SDH controller does not > support 4-bit mode MMC card. Please found the table picture in the >

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Pierre Ossman
On Thu, 10 Jan 2008 00:45:27 +0800 "Bryan Wu" <[EMAIL PROTECTED]> wrote: > > Actually, Blackfin BF54x on-chip SDIO host controller is supposed to > support 1-bit and 4-bit MMC or SD. But in the real platform, when MMC > works at 4-bit mode there will be a FIFO underrun error >

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Pierre Ossman
On Thu, 10 Jan 2008 00:45:27 +0800 Bryan Wu [EMAIL PROTECTED] wrote: Actually, Blackfin BF54x on-chip SDIO host controller is supposed to support 1-bit and 4-bit MMC or SD. But in the real platform, when MMC works at 4-bit mode there will be a FIFO underrun error

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Pierre Ossman
On Thu, 10 Jan 2008 17:22:55 +0800 Bryan Wu [EMAIL PROTECTED] wrote: At page 4-3 of ADSP-BF54x Blackfin(R) Processor Peripheral Hardware Reference, there is a table which guide us the SDH controller does not support 4-bit mode MMC card. Please found the table picture in the attachment or

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Bryan Wu
On Jan 10, 2008 7:57 PM, Pierre Ossman [EMAIL PROTECTED] wrote: On Thu, 10 Jan 2008 17:22:55 +0800 Bryan Wu [EMAIL PROTECTED] wrote: At page 4-3 of ADSP-BF54x Blackfin(R) Processor Peripheral Hardware Reference, there is a table which guide us the SDH controller does not support 4-bit

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-10 Thread Mike Frysinger
On Jan 11, 2008 1:17 AM, Bryan Wu [EMAIL PROTECTED] wrote: On Jan 10, 2008 7:57 PM, Pierre Ossman [EMAIL PROTECTED] wrote: On Thu, 10 Jan 2008 17:22:55 +0800 Bryan Wu [EMAIL PROTECTED] wrote: At page 4-3 of ADSP-BF54x Blackfin(R) Processor Peripheral Hardware Reference, there is a

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-09 Thread Bryan Wu
On Jan 9, 2008 3:23 PM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Wed, 9 Jan 2008 11:21:40 +0800 > "Cai, Cliff" <[EMAIL PROTECTED]> wrote: > > > > > Hi,all > > > > I'd like to say something about this issue. > > Currently,the blackfin on chip SD host ONLY support 1-bit MMC while > > support

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-09 Thread Bryan Wu
On Jan 9, 2008 3:23 PM, Pierre Ossman [EMAIL PROTECTED] wrote: On Wed, 9 Jan 2008 11:21:40 +0800 Cai, Cliff [EMAIL PROTECTED] wrote: Hi,all I'd like to say something about this issue. Currently,the blackfin on chip SD host ONLY support 1-bit MMC while support 1-bit/4-bit SD/SDIO.

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Wed, 9 Jan 2008 11:21:40 +0800 "Cai, Cliff" <[EMAIL PROTECTED]> wrote: > > Hi,all > > I'd like to say something about this issue. > Currently,the blackfin on chip SD host ONLY support 1-bit MMC while > support 1-bit/4-bit SD/SDIO. > And we want our driver to support both 1-bit MMC and 4-bit

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Tue, 8 Jan 2008 16:44:08 -0500 "Mike Frysinger" <[EMAIL PROTECTED]> wrote: > On Jan 8, 2008 3:49 PM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > > So, again, if you feel that there is a hardware difference between 4-bit > > MMC and 4-bit SD then please elaborate as it is my understanding that

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Bryan Wu
On Jan 9, 2008 2:29 AM, Mike Frysinger <[EMAIL PROTECTED]> wrote: > The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit > MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of > MMC_CAP_4_BIT_DATA meaning "your host controller can do 1-bit or 4-bit for

RE: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Cai, Cliff
] Cc: Mike Frysinger; linux-kernel@vger.kernel.org Subject: Re: [patch] split MMC_CAP_4_BIT_DATA On Jan 9, 2008 4:49 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Tue, 8 Jan 2008 14:40:49 -0500 > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > > > > i dont understan

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Bryan Wu
On Jan 9, 2008 4:49 AM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Tue, 8 Jan 2008 14:40:49 -0500 > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > > > > i dont understand what's confusing. the Blackfin on chip host controller > > only > > supports 1-bit MMC, but it supports 4-bit SD/SDIO.

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Mike Frysinger
On Jan 8, 2008 3:49 PM, Pierre Ossman <[EMAIL PROTECTED]> wrote: > On Tue, 8 Jan 2008 14:40:49 -0500 > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > i dont understand what's confusing. the Blackfin on chip host controller > > only > > supports 1-bit MMC, but it supports 4-bit SD/SDIO. this is a

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Tue, 8 Jan 2008 14:40:49 -0500 Mike Frysinger <[EMAIL PROTECTED]> wrote: > > i dont understand what's confusing. the Blackfin on chip host controller > only > supports 1-bit MMC, but it supports 4-bit SD/SDIO. this is a fact. while it > may be a stupid decision, it is what it is, and i

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Mike Frysinger
On Tuesday 08 January 2008 14:21:57 Pierre Ossman wrote: > Mike Frysinger <[EMAIL PROTECTED]> wrote: > > The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do > > 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current > > convention of MMC_CAP_4_BIT_DATA meaning "your

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Tue, 8 Jan 2008 13:29:39 -0500 Mike Frysinger <[EMAIL PROTECTED]> wrote: > The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit > MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of > MMC_CAP_4_BIT_DATA meaning "your host controller can do 1-bit

[patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Mike Frysinger
The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of MMC_CAP_4_BIT_DATA meaning "your host controller can do 1-bit or 4-bit for all modes" is insufficient for our needs. The attached patch splits

[patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Mike Frysinger
The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of MMC_CAP_4_BIT_DATA meaning your host controller can do 1-bit or 4-bit for all modes is insufficient for our needs. The attached patch splits

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Tue, 8 Jan 2008 13:29:39 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of MMC_CAP_4_BIT_DATA meaning your host controller can do 1-bit or

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Mike Frysinger
On Tuesday 08 January 2008 14:21:57 Pierre Ossman wrote: Mike Frysinger [EMAIL PROTECTED] wrote: The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of MMC_CAP_4_BIT_DATA meaning your host

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Tue, 8 Jan 2008 14:40:49 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: i dont understand what's confusing. the Blackfin on chip host controller only supports 1-bit MMC, but it supports 4-bit SD/SDIO. this is a fact. while it may be a stupid decision, it is what it is, and i need

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Mike Frysinger
On Jan 8, 2008 3:49 PM, Pierre Ossman [EMAIL PROTECTED] wrote: On Tue, 8 Jan 2008 14:40:49 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: i dont understand what's confusing. the Blackfin on chip host controller only supports 1-bit MMC, but it supports 4-bit SD/SDIO. this is a fact.

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Bryan Wu
On Jan 9, 2008 4:49 AM, Pierre Ossman [EMAIL PROTECTED] wrote: On Tue, 8 Jan 2008 14:40:49 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: i dont understand what's confusing. the Blackfin on chip host controller only supports 1-bit MMC, but it supports 4-bit SD/SDIO. this is a fact.

RE: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Cai, Cliff
] Cc: Mike Frysinger; linux-kernel@vger.kernel.org Subject: Re: [patch] split MMC_CAP_4_BIT_DATA On Jan 9, 2008 4:49 AM, Pierre Ossman [EMAIL PROTECTED] wrote: On Tue, 8 Jan 2008 14:40:49 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: i dont understand what's confusing. the Blackfin on chip

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Bryan Wu
On Jan 9, 2008 2:29 AM, Mike Frysinger [EMAIL PROTECTED] wrote: The on-chip Blackfin MMC/SD/SDIO host controller has the ability to do 1-bit MMC, 1-bit/4-bit SD, and 1-bit/4-bit SDIO. Thus the current convention of MMC_CAP_4_BIT_DATA meaning your host controller can do 1-bit or 4-bit for all

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Wed, 9 Jan 2008 11:21:40 +0800 Cai, Cliff [EMAIL PROTECTED] wrote: Hi,all I'd like to say something about this issue. Currently,the blackfin on chip SD host ONLY support 1-bit MMC while support 1-bit/4-bit SD/SDIO. And we want our driver to support both 1-bit MMC and 4-bit

Re: [patch] split MMC_CAP_4_BIT_DATA

2008-01-08 Thread Pierre Ossman
On Tue, 8 Jan 2008 16:44:08 -0500 Mike Frysinger [EMAIL PROTECTED] wrote: On Jan 8, 2008 3:49 PM, Pierre Ossman [EMAIL PROTECTED] wrote: So, again, if you feel that there is a hardware difference between 4-bit MMC and 4-bit SD then please elaborate as it is my understanding that they are