Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-26 Thread Ben Myers
Hey Dan, On Mon, Aug 26, 2013 at 05:37:15PM +0300, Dan Carpenter wrote: > On Fri, Aug 23, 2013 at 12:36:13PM -0500, Ben Myers wrote: > > Dan, > > > > On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: > > > On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: > > > > Hey Dan & Je

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-26 Thread Dan Carpenter
On Fri, Aug 23, 2013 at 12:36:13PM -0500, Ben Myers wrote: > Dan, > > On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: > > On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: > > > Hey Dan & Jeff, > > > > > > On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: > > > > On

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-23 Thread Ben Myers
Dan, On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: > On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: > > Hey Dan & Jeff, > > > > On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: > > > On 08/15/2013 01:53 PM, Dan Carpenter wrote: > > > > > > > The "di_size" var

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-15 Thread Dave Chinner
On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: > Hey Dan & Jeff, > > On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: > > On 08/15/2013 01:53 PM, Dan Carpenter wrote: > > > > > The "di_size" variable comes from the disk and it's a signed 64 bit. > > > We check the upper limit

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-15 Thread Dan Carpenter
On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: > Hey Dan & Jeff, > > On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: > > On 08/15/2013 01:53 PM, Dan Carpenter wrote: > > > > > The "di_size" variable comes from the disk and it's a signed 64 bit. > > > We check the upper limit

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-15 Thread Ben Myers
Hey Dan & Jeff, On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: > On 08/15/2013 01:53 PM, Dan Carpenter wrote: > > > The "di_size" variable comes from the disk and it's a signed 64 bit. > > We check the upper limit but we should check for negative numbers as > > well. > > > > Signed-of

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-15 Thread Jeff Liu
On 08/15/2013 01:53 PM, Dan Carpenter wrote: > The "di_size" variable comes from the disk and it's a signed 64 bit. > We check the upper limit but we should check for negative numbers as > well. > > Signed-off-by: Dan Carpenter > > diff --git a/fs/xfs/xfs_inode_fork.c b/fs/xfs/xfs_inode_fork.c

[patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-14 Thread Dan Carpenter
The "di_size" variable comes from the disk and it's a signed 64 bit. We check the upper limit but we should check for negative numbers as well. Signed-off-by: Dan Carpenter diff --git a/fs/xfs/xfs_inode_fork.c b/fs/xfs/xfs_inode_fork.c index 123971b..849fc70 100644 --- a/fs/xfs/xfs_inode_fork.c