On Tue, Jan 23, 2007 at 01:59:14PM +0200, Alon Bar-Lev wrote:
> On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
> >> Rossell, I am confused.
> >> There are many places in kernel where there is static __initdata
> >> without initialization. Should all these be corrected too? Or your
> >> comment
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
> Rossell, I am confused.
> There are many places in kernel where there is static __initdata
> without initialization. Should all these be corrected too? Or your
> comment applies only to none static global data?
From what I remembered from pre
On Tue, Jan 23, 2007 at 01:31:25PM +0200, Alon Bar-Lev wrote:
> On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
> >> So it will be fine if I initialize it to "" and remove the static from
> >> the your example?
> >
> >Why do you want to remove the static?
>
> Rossell, I am confused.
> There ar
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
> So it will be fine if I initialize it to "" and remove the static from
> the your example?
Why do you want to remove the static?
Rossell, I am confused.
There are many places in kernel where there is static __initdata
without initialization
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
Why do you want to remove the static?
Since current design declare a buffer in main.c which is used by arch
specific startup code, mainly setup.c.
Regards,
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel
On Tue, Jan 23, 2007 at 12:50:15PM +0200, Alon Bar-Lev wrote:
> On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
> >See Message-ID: <[EMAIL PROTECTED]> sent on
> >18 January in this thread. Such strings might as well be initialised to
> >an empty string.
>
> So it will be fine if I initialize
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
See Message-ID: <[EMAIL PROTECTED]> sent on
18 January in this thread. Such strings might as well be initialised to
an empty string.
So it will be fine if I initialize it to "" and remove the static from
the your example?
BTW: Is there a diff
On Tue, Jan 23, 2007 at 12:37:06PM +0200, Alon Bar-Lev wrote:
> On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
> >which reflects precisely what I've been saying concerning the addition
> >of __initdata.
>
> Great!
> So what do you thing we should do?
>
> Modify this:
> char __initdata boot_c
On 1/23/07, Russell King <[EMAIL PROTECTED]> wrote:
which reflects precisely what I've been saying concerning the addition
of __initdata.
Great!
So what do you thing we should do?
Modify this:
char __initdata boot_command_line[COMMAND_LINE_SIZE];
Into:
char __initdata boot_command_line[COMMAN
* Russell King <[EMAIL PROTECTED]> [2007-01-22 23:27]:
>
> which reflects precisely what I've been saying concerning the addition
> of __initdata.
100 % correct, thanks.
Regards,
Bernhard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAI
On Mon, Jan 22, 2007 at 11:14:00PM +0100, Bernhard Walle wrote:
> * Russell King <[EMAIL PROTECTED]> [2007-01-18 16:23]:
> > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote:
> > > Russell King wrote:
> > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
> > > >> -s
* Russell King <[EMAIL PROTECTED]> [2007-01-18 16:23]:
> On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote:
> > Russell King wrote:
> > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
> > >> -static char command_line[COMMAND_LINE_SIZE];
> > >> +static char __initdata
On 1/22/07, Bernhard Walle <[EMAIL PROTECTED]> wrote:
I refreshed the patches from Alon against 2.6.20-rc4-mm1. Or was I
totally wrong?
I don't know what is "Avoid top-posting? ;)" I hope it is a good thing... :)
I will look at it again and submit it as requested.
Thank you,
Alon Bar-Lev.
-
To
* Andrew Morton <[EMAIL PROTECTED]> [2007-01-22 21:44]:
>
> > Some general comments... or should I CC other people etc...
> > I submitted this several times but got almost no architecture to ACK.
> >
> > I just don't know how we can progress with this issue... All we wanted
> > is to break the 25
On Mon, 22 Jan 2007 22:31:48 +0200
"Alon Bar-Lev" <[EMAIL PROTECTED]> wrote:
> Hello Andrew,
>
> Can I do anything more in order to be closer to merge?
Avoid top-posting? ;)
> Some general comments... or should I CC other people etc...
> I submitted this several times but got almost no architec
Hello Andrew,
Can I do anything more in order to be closer to merge?
Some general comments... or should I CC other people etc...
I submitted this several times but got almost no architecture to ACK.
I just don't know how we can progress with this issue... All we wanted
is to break the 256 limit
On Mon, Jan 22, 2007 at 11:56:50AM -0800, Andrew Morton wrote:
> > On Thu, 18 Jan 2007 15:23:26 + Russell King <[EMAIL PROTECTED]> wrote:
> > On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote:
> > > Russell King wrote:
> > > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Wall
> On Thu, 18 Jan 2007 15:23:26 + Russell King <[EMAIL PROTECTED]> wrote:
> On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote:
> > Russell King wrote:
> > > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
> > >> -static char command_line[COMMAND_LINE_SIZE];
> > >> +
On 1/18/07, Bodo Eggert <[EMAIL PROTECTED]> wrote:
Alon Bar-Lev <[EMAIL PROTECTED]> wrote:
> On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote:
>> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
>> > 2. Set command_line as __initdata.
>> You can't.
>>
>> > -static char command_l
* Russell King <[EMAIL PROTECTED]> [2007-01-18 16:23]:
>
> However, there is a bigger question here: that is the tradeoff between
> making this variable part of the on-disk kernel image, but throw away
> the memory at runtime, or to leave it in the BSS where it will not be
> part of the on-disk ke
Alon Bar-Lev <[EMAIL PROTECTED]> wrote:
> On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote:
>> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
>> > 2. Set command_line as __initdata.
>> You can't.
>>
>> > -static char command_line[COMMAND_LINE_SIZE];
>> > +static char __initdata
On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote:
If you want to place a variable in a specific section, it must be
explicitly initialised. Eg,
static char __initdata command_line[COMMAND_LINE_SIZE] = "";
However, there is a bigger question here: that is the tradeoff between
making this vari
On Thu, Jan 18, 2007 at 04:31:51PM +0100, Tomas Carnecky wrote:
> Russell King wrote:
> > On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
> >> -static char command_line[COMMAND_LINE_SIZE];
> >> +static char __initdata command_line[COMMAND_LINE_SIZE];
> >
> > Uninitialised data is
Russell King wrote:
> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
>> -static char command_line[COMMAND_LINE_SIZE];
>> +static char __initdata command_line[COMMAND_LINE_SIZE];
>
> Uninitialised data is placed in the BSS. Adding __initdata to BSS
> data causes grief.
>
Static
On 1/18/07, Russell King <[EMAIL PROTECTED]> wrote:
On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
> 2. Set command_line as __initdata.
You can't.
> -static char command_line[COMMAND_LINE_SIZE];
> +static char __initdata command_line[COMMAND_LINE_SIZE];
Uninitialised data is p
On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote:
> 2. Set command_line as __initdata.
You can't.
> -static char command_line[COMMAND_LINE_SIZE];
> +static char __initdata command_line[COMMAND_LINE_SIZE];
Uninitialised data is placed in the BSS. Adding __initdata to BSS
data cause
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
arch/arm/kernel/setup.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6.20-rc4-mm1/arch/arm/kernel/setup.c
1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.
Signed-off-by: Alon Bar-Lev <[EMAIL PROTECTED]>
---
diff -urNp linux-2.6.19.org/arch/arm/kernel/setup.c
linux-2.6.19/arch/arm/kernel/setup.c
--- linux-2.6.19.org/arch/arm/kernel/setup.c2006-11-29 23:57:
28 matches
Mail list logo