Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > Chris Wright wrote: > > I mean like this (bunch of work, for a type check that we're really ignoring > > anwyay, but this is the idea...) > > Oh, I see. I think this is the best argument yet for the current > arrangement... Heh, like I said

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Jeremy Fitzhardinge
Chris Wright wrote: > I mean like this (bunch of work, for a type check that we're really ignoring > anwyay, but this is the idea...) > Oh, I see. I think this is the best argument yet for the current arrangement... J - To unsubscribe from this list: send the line "unsubscribe

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > Chris Wright wrote: > > how about __paravirt_nop_start < func < __paravirt_nop_end and preserve > > the types? > > > > Er? The reason for the (void *) cast is to stop gcc complaining about > mismatched pointer types. I mean like this (bunch

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Jeremy Fitzhardinge
Chris Wright wrote: > how about __paravirt_nop_start < func < __paravirt_nop_end and preserve > the types? > Er? The reason for the (void *) cast is to stop gcc complaining about mismatched pointer types. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > Ingo Molnar wrote: > > but only as a cleanup of the current open-coded (void *) casts. My > > problem with this is that it loses the types. Not that there is much to > > check for, but still, this adds some assumptions about how function > >

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > but only as a cleanup of the current open-coded (void *) casts. My > problem with this is that it loses the types. Not that there is much to > check for, but still, this adds some assumptions about how function > calls look like. I agree. I don't generally like this kind

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Add a _paravirt_nop function for use as a stub for no-op operations, > and paravirt_nop #defined void * version to make using it easier > (since all its uses are as a void *). > > This is useful to allow the patcher to automatically identify

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Ingo Molnar
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Add a _paravirt_nop function for use as a stub for no-op operations, and paravirt_nop #defined void * version to make using it easier (since all its uses are as a void *). This is useful to allow the patcher to automatically identify noop

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: but only as a cleanup of the current open-coded (void *) casts. My problem with this is that it loses the types. Not that there is much to check for, but still, this adds some assumptions about how function calls look like. I agree. I don't generally like this kind of

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: Ingo Molnar wrote: but only as a cleanup of the current open-coded (void *) casts. My problem with this is that it loses the types. Not that there is much to check for, but still, this adds some assumptions about how function calls look

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Jeremy Fitzhardinge
Chris Wright wrote: how about __paravirt_nop_start func __paravirt_nop_end and preserve the types? Er? The reason for the (void *) cast is to stop gcc complaining about mismatched pointer types. J - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: Chris Wright wrote: how about __paravirt_nop_start func __paravirt_nop_end and preserve the types? Er? The reason for the (void *) cast is to stop gcc complaining about mismatched pointer types. I mean like this (bunch of work,

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Jeremy Fitzhardinge
Chris Wright wrote: I mean like this (bunch of work, for a type check that we're really ignoring anwyay, but this is the idea...) Oh, I see. I think this is the best argument yet for the current arrangement... J - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: Chris Wright wrote: I mean like this (bunch of work, for a type check that we're really ignoring anwyay, but this is the idea...) Oh, I see. I think this is the best argument yet for the current arrangement... Heh, like I said it's a

[patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-01 Thread Jeremy Fitzhardinge
Add a _paravirt_nop function for use as a stub for no-op operations, and paravirt_nop #defined void * version to make using it easier (since all its uses are as a void *). This is useful to allow the patcher to automatically identify noop operations so it can simply nop out the callsite.

[patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-03-01 Thread Jeremy Fitzhardinge
Add a _paravirt_nop function for use as a stub for no-op operations, and paravirt_nop #defined void * version to make using it easier (since all its uses are as a void *). This is useful to allow the patcher to automatically identify noop operations so it can simply nop out the callsite.

[patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-02-27 Thread Jeremy Fitzhardinge
Add a _paravirt_nop function for use as a stub for no-op operations, and paravirt_nop #defined void * version to make using it easier (since all its uses are as a void *). This is useful to allow the patcher to automatically identify noop operations so it can simply nop out the callsite.

[patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

2007-02-27 Thread Jeremy Fitzhardinge
Add a _paravirt_nop function for use as a stub for no-op operations, and paravirt_nop #defined void * version to make using it easier (since all its uses are as a void *). This is useful to allow the patcher to automatically identify noop operations so it can simply nop out the callsite.