Re: [Xen-devel] Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > On Wed, 2007-02-21 at 23:15 +0100, Andi Kleen wrote: > >> On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote: >> >>> Add a set of accessors to pack, unpack and modify page table entries >>> (at all levels). This allows a paravirt implementation to

Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Rusty Russell
On Wed, 2007-02-21 at 23:15 +0100, Andi Kleen wrote: > On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote: > > Add a set of accessors to pack, unpack and modify page table entries > > (at all levels). This allows a paravirt implementation to control the > > contents of pgd/pmd/pte

Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > Do you have some lmbench numbers before/after this change? > iirc at least fork and exit do a lot of pte accesses in various forms. > If it's measurable it might be needed to patch those for the native case. > I don't. I think Rusty ran some numbers and found the pte

Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Andi Kleen
On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote: > Add a set of accessors to pack, unpack and modify page table entries > (at all levels). This allows a paravirt implementation to control the > contents of pgd/pmd/pte entries. For example, Xen uses this to > convert the

Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Andi Kleen
On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote: Add a set of accessors to pack, unpack and modify page table entries (at all levels). This allows a paravirt implementation to control the contents of pgd/pmd/pte entries. For example, Xen uses this to convert the

Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Jeremy Fitzhardinge
Andi Kleen wrote: Do you have some lmbench numbers before/after this change? iirc at least fork and exit do a lot of pte accesses in various forms. If it's measurable it might be needed to patch those for the native case. I don't. I think Rusty ran some numbers and found the pte

Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Rusty Russell
On Wed, 2007-02-21 at 23:15 +0100, Andi Kleen wrote: On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote: Add a set of accessors to pack, unpack and modify page table entries (at all levels). This allows a paravirt implementation to control the contents of pgd/pmd/pte entries.

Re: [Xen-devel] Re: [patch 05/24] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

2007-02-21 Thread Jeremy Fitzhardinge
Rusty Russell wrote: On Wed, 2007-02-21 at 23:15 +0100, Andi Kleen wrote: On Wednesday 21 February 2007 21:52, Jeremy Fitzhardinge wrote: Add a set of accessors to pack, unpack and modify page table entries (at all levels). This allows a paravirt implementation to control the