Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-14 Thread Pavel Machek
Hi! > >>This adds the ability for the file system to remounted as read only > >>during a > >>system suspend. Log the mount points so when the resume occurs, they can > >>be remounted back to their original states. This is so in an advent of a > >>power > >>failure, we try our best to keep

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-14 Thread Pavel Machek
Hi! This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This is so in an advent of a power failure, we try our best to keep data from being

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-13 Thread Pavel Machek
Hi! > > Why do you think remounting filesystems is necessary? Are you getting > > problems with some particular filesystem? > > No. But anything in a removable device neets to be either remounted > read-only or unmounted if that is at all possible, because the user could > unplug it. It is of

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-13 Thread Pavel Machek
Hi! Why do you think remounting filesystems is necessary? Are you getting problems with some particular filesystem? No. But anything in a removable device neets to be either remounted read-only or unmounted if that is at all possible, because the user could unplug it. It is of course,

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-09 Thread Pavel Machek
On Wed 2007-02-07 09:25:39, Henrique de Moraes Holschuh wrote: > On Wed, 07 Feb 2007, Nigel Cunningham wrote: > > Ok, as far as usage scenario goes, that's fair enough. But as to the > > solution, I wonder though whether it's making life more complicated than > > it needs to be. After all, we

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-09 Thread Pavel Machek
On Wed 2007-02-07 09:25:39, Henrique de Moraes Holschuh wrote: On Wed, 07 Feb 2007, Nigel Cunningham wrote: Ok, as far as usage scenario goes, that's fair enough. But as to the solution, I wonder though whether it's making life more complicated than it needs to be. After all, we should also

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Rafael J. Wysocki
On Wednesday, 7 February 2007 13:05, Henrique de Moraes Holschuh wrote: > On Wed, 07 Feb 2007, Nigel Cunningham wrote: > > > We don't cope okay with the power going out, at all. And as an user > > > case, a > > > need for fsck if you do something that is a reasonable use case > > > (unplugging

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Henrique de Moraes Holschuh
On Wed, 07 Feb 2007, Nigel Cunningham wrote: > > We don't cope okay with the power going out, at all. And as an user case, a > > need for fsck if you do something that is a reasonable use case (unplugging > > devices while suspended) is not okay, either. > > Maybe it depends on the filesystem

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Nigel Cunningham
Hi. On Wed, 2007-02-07 at 09:25 -0200, Henrique de Moraes Holschuh wrote: > On Wed, 07 Feb 2007, Nigel Cunningham wrote: > > Ok, as far as usage scenario goes, that's fair enough. But as to the > > solution, I wonder though whether it's making life more complicated than > > it needs to be. After

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Henrique de Moraes Holschuh
On Wed, 07 Feb 2007, Nigel Cunningham wrote: > Ok, as far as usage scenario goes, that's fair enough. But as to the > solution, I wonder though whether it's making life more complicated than > it needs to be. After all, we should also be able to cope okay with > having the power suddenly go out.

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Henrique de Moraes Holschuh
On Wed, 07 Feb 2007, Nigel Cunningham wrote: Ok, as far as usage scenario goes, that's fair enough. But as to the solution, I wonder though whether it's making life more complicated than it needs to be. After all, we should also be able to cope okay with having the power suddenly go out. If we

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Nigel Cunningham
Hi. On Wed, 2007-02-07 at 09:25 -0200, Henrique de Moraes Holschuh wrote: On Wed, 07 Feb 2007, Nigel Cunningham wrote: Ok, as far as usage scenario goes, that's fair enough. But as to the solution, I wonder though whether it's making life more complicated than it needs to be. After all, we

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Henrique de Moraes Holschuh
On Wed, 07 Feb 2007, Nigel Cunningham wrote: We don't cope okay with the power going out, at all. And as an user case, a need for fsck if you do something that is a reasonable use case (unplugging devices while suspended) is not okay, either. Maybe it depends on the filesystem you use.

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-07 Thread Rafael J. Wysocki
On Wednesday, 7 February 2007 13:05, Henrique de Moraes Holschuh wrote: On Wed, 07 Feb 2007, Nigel Cunningham wrote: We don't cope okay with the power going out, at all. And as an user case, a need for fsck if you do something that is a reasonable use case (unplugging devices

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-06 Thread Nigel Cunningham
Hi. On Tue, 2007-02-06 at 12:32 -0200, Henrique de Moraes Holschuh wrote: > On Tue, 06 Feb 2007, Nigel Cunningham wrote: > > Why do you think remounting filesystems is necessary? Are you getting > > problems with some particular filesystem? > > No. But anything in a removable device neets to be

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-06 Thread Rafael J. Wysocki
On Tuesday, 6 February 2007 15:32, Henrique de Moraes Holschuh wrote: > On Tue, 06 Feb 2007, Nigel Cunningham wrote: > > Why do you think remounting filesystems is necessary? Are you getting > > problems with some particular filesystem? > > No. But anything in a removable device neets to be

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-06 Thread Henrique de Moraes Holschuh
On Tue, 06 Feb 2007, Nigel Cunningham wrote: > Why do you think remounting filesystems is necessary? Are you getting > problems with some particular filesystem? No. But anything in a removable device neets to be either remounted read-only or unmounted if that is at all possible, because the user

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-06 Thread Henrique de Moraes Holschuh
On Tue, 06 Feb 2007, Nigel Cunningham wrote: Why do you think remounting filesystems is necessary? Are you getting problems with some particular filesystem? No. But anything in a removable device neets to be either remounted read-only or unmounted if that is at all possible, because the user

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-06 Thread Rafael J. Wysocki
On Tuesday, 6 February 2007 15:32, Henrique de Moraes Holschuh wrote: On Tue, 06 Feb 2007, Nigel Cunningham wrote: Why do you think remounting filesystems is necessary? Are you getting problems with some particular filesystem? No. But anything in a removable device neets to be either

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-06 Thread Nigel Cunningham
Hi. On Tue, 2007-02-06 at 12:32 -0200, Henrique de Moraes Holschuh wrote: On Tue, 06 Feb 2007, Nigel Cunningham wrote: Why do you think remounting filesystems is necessary? Are you getting problems with some particular filesystem? No. But anything in a removable device neets to be either

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-05 Thread Christoph Hellwig
On Tue, Feb 06, 2007 at 08:28:33AM +1100, Nigel Cunningham wrote: > Why do you think remounting filesystems is necessary? Are you getting > problems with some particular filesystem? > > If I recall correctly, we briefly tried remounting filesystems in > Suspend2, but it created problems with

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-05 Thread Nigel Cunningham
Hi. On Fri, 2007-02-02 at 22:35 -0200, Henrique de Moraes Holschuh wrote: > On Fri, 02 Feb 2007, Andrew Morton wrote: > > Well the code appears simple enough, but I've not previously heard anyone > > express a need for this feature. But I know how to cc people who might > > have heard this. > >

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-05 Thread Christoph Hellwig
On Sat, Feb 03, 2007 at 03:34:57PM -1000, akuster wrote: > >Can you please explain why this can't be done in userspace? > > I am sure it can. The idea came from customer inputs, speed is my > guess. echo mem > /sys/../state seems a whole lot simpler and cleaner > than having userspace figure

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-05 Thread Christoph Hellwig
On Sat, Feb 03, 2007 at 03:34:57PM -1000, akuster wrote: Can you please explain why this can't be done in userspace? I am sure it can. The idea came from customer inputs, speed is my guess. echo mem /sys/../state seems a whole lot simpler and cleaner than having userspace figure out

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-05 Thread Nigel Cunningham
Hi. On Fri, 2007-02-02 at 22:35 -0200, Henrique de Moraes Holschuh wrote: On Fri, 02 Feb 2007, Andrew Morton wrote: Well the code appears simple enough, but I've not previously heard anyone express a need for this feature. But I know how to cc people who might have heard this. You are,

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-05 Thread Christoph Hellwig
On Tue, Feb 06, 2007 at 08:28:33AM +1100, Nigel Cunningham wrote: Why do you think remounting filesystems is necessary? Are you getting problems with some particular filesystem? If I recall correctly, we briefly tried remounting filesystems in Suspend2, but it created problems with logging -

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-03 Thread akuster
Christoph Hellwig wrote: On Fri, Feb 02, 2007 at 01:50:10PM -1000, [EMAIL PROTECTED] wrote: This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-03 Thread Pavel Machek
Hi! > This adds the ability for the file system to remounted as read only during a > system suspend. Log the mount points so when the resume occurs, they can be > remounted back to their original states. This is so in an advent of a power > failure, we try our best to keep data from being

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-03 Thread Christoph Hellwig
On Fri, Feb 02, 2007 at 01:50:10PM -1000, [EMAIL PROTECTED] wrote: > > > This adds the ability for the file system to remounted as read only during a > system suspend. Log the mount points so when the resume occurs, they can be > remounted back to their original states. This is so in an advent

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-03 Thread Christoph Hellwig
On Fri, Feb 02, 2007 at 01:50:10PM -1000, [EMAIL PROTECTED] wrote: This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This is so in an advent of a

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-03 Thread Pavel Machek
Hi! This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This is so in an advent of a power failure, we try our best to keep data from being corrupted

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-03 Thread akuster
Christoph Hellwig wrote: On Fri, Feb 02, 2007 at 01:50:10PM -1000, [EMAIL PROTECTED] wrote: This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread akuster
Andrew Morton wrote: On Fri, 02 Feb 2007 13:50:10 -1000 [EMAIL PROTECTED] wrote: +struct suspremount { +struct super_block *sb; +struct suspremount *next; +}; The fields of this struct need a leading tab. ok. The name "suspremount" might be unpopular. suspend_remount_state would

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread Henrique de Moraes Holschuh
On Fri, 02 Feb 2007, Andrew Morton wrote: > Well the code appears simple enough, but I've not previously heard anyone > express a need for this feature. But I know how to cc people who might > have heard this. You are, now. We usually try to do it in userspace (and it gets ugly when we fail).

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread Andrew Morton
On Fri, 02 Feb 2007 13:50:10 -1000 [EMAIL PROTECTED] wrote: > > > This adds the ability for the file system to remounted as read only during a > system suspend. Log the mount points so when the resume occurs, they can be > remounted back to their original states. This is so in an advent of a

[patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread akuster
This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This is so in an advent of a power failure, we try our best to keep data from being corrupted or

[patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread akuster
This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This is so in an advent of a power failure, we try our best to keep data from being corrupted or

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread Andrew Morton
On Fri, 02 Feb 2007 13:50:10 -1000 [EMAIL PROTECTED] wrote: This adds the ability for the file system to remounted as read only during a system suspend. Log the mount points so when the resume occurs, they can be remounted back to their original states. This is so in an advent of a power

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread Henrique de Moraes Holschuh
On Fri, 02 Feb 2007, Andrew Morton wrote: Well the code appears simple enough, but I've not previously heard anyone express a need for this feature. But I know how to cc people who might have heard this. You are, now. We usually try to do it in userspace (and it gets ugly when we fail). If

Re: [patch 1/1] PM: Adds remount fs ro at suspend

2007-02-02 Thread akuster
Andrew Morton wrote: On Fri, 02 Feb 2007 13:50:10 -1000 [EMAIL PROTECTED] wrote: snipped +struct suspremount { +struct super_block *sb; +struct suspremount *next; +}; The fields of this struct need a leading tab. ok. The name suspremount might be unpopular. suspend_remount_state