Re: [patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-28 Thread Andi Kleen
> The new API is a lot simpler, and it is INTENT driven. > This means that PAT (for 2.6.26) no longer has to second guess various things > and capabilities, it just gets a set_memory_uc() or set_memory_wc() call and AFAIK there is no valid use case where you would ever change PAT bits on a page

Re: [patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-28 Thread Arjan van de Ven
On Mon, 28 Jan 2008 15:56:21 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > Right now, if drivers or other code want to change, say, a cache > > attribute of a page, the only API they have is change_page_attr(). > > c-p-a is a really bad API for

Re: [patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-28 Thread Andi Kleen
Arjan van de Ven <[EMAIL PROTECTED]> writes: > Right now, if drivers or other code want to change, say, a cache attribute of > a > page, the only API they have is change_page_attr(). c-p-a is a really bad API > for this, because it forces the caller to know *ALL* the attributes he wants > for

Re: [patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-28 Thread Andi Kleen
The new API is a lot simpler, and it is INTENT driven. This means that PAT (for 2.6.26) no longer has to second guess various things and capabilities, it just gets a set_memory_uc() or set_memory_wc() call and AFAIK there is no valid use case where you would ever change PAT bits on a page you

Re: [patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-28 Thread Andi Kleen
Arjan van de Ven [EMAIL PROTECTED] writes: Right now, if drivers or other code want to change, say, a cache attribute of a page, the only API they have is change_page_attr(). c-p-a is a really bad API for this, because it forces the caller to know *ALL* the attributes he wants for the page,

Re: [patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-28 Thread Arjan van de Ven
On Mon, 28 Jan 2008 15:56:21 +0100 Andi Kleen [EMAIL PROTECTED] wrote: Arjan van de Ven [EMAIL PROTECTED] writes: Right now, if drivers or other code want to change, say, a cache attribute of a page, the only API they have is change_page_attr(). c-p-a is a really bad API for this,

[patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-25 Thread Arjan van de Ven
Subject: x86: a new API for drivers/etc to control cache and other page attributes From: Arjan van de Ven <[EMAIL PROTECTED]> Right now, if drivers or other code want to change, say, a cache attribute of a page, the only API they have is change_page_attr(). c-p-a is a really bad API for this,

[patch 1/3] x86: a new API for drivers/etc to control cache and other page attributes

2008-01-25 Thread Arjan van de Ven
Subject: x86: a new API for drivers/etc to control cache and other page attributes From: Arjan van de Ven [EMAIL PROTECTED] Right now, if drivers or other code want to change, say, a cache attribute of a page, the only API they have is change_page_attr(). c-p-a is a really bad API for this,