Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Richard Knutsson
Arjan van de Ven wrote: On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example... You mean because in that

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Arjan van de Ven
On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: > >> (btw, wouldn't 'var != 0' actually be the proper semantic instead > >> of playing with '!'s?) > >> > > > > no because var could be a pointer for example... > > > You mean because in that case it would be

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Richard Knutsson
Arjan van de Ven wrote: On Sun, 06 Jan 2008 12:44:56 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Arjan van de Ven
On Sun, 06 Jan 2008 12:44:56 +0100 Richard Knutsson <[EMAIL PROTECTED]> wrote: > Arjan van de Ven wrote: > > From: Olof Johansson <[EMAIL PROTECTED]> > > > > Introduce __WARN() in the generic case, so the generic WARN_ON() > > can use arch-specific code for when the condition is true. > > > >

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Richard Knutsson
Arjan van de Ven wrote: From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Richard Knutsson
Arjan van de Ven wrote: From: Olof Johansson [EMAIL PROTECTED] Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Arjan van de Ven
On Sun, 06 Jan 2008 12:44:56 +0100 Richard Knutsson [EMAIL PROTECTED] wrote: Arjan van de Ven wrote: From: Olof Johansson [EMAIL PROTECTED] Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Arjan van de Ven
On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson [EMAIL PROTECTED] wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example... You mean because in that case it would be '!= NULL', do you?

Re: [patch 1/5] Introduce __WARN()

2008-01-06 Thread Richard Knutsson
Arjan van de Ven wrote: On Sun, 06 Jan 2008 17:09:44 +0100 Richard Knutsson [EMAIL PROTECTED] wrote: (btw, wouldn't 'var != 0' actually be the proper semantic instead of playing with '!'s?) no because var could be a pointer for example... You mean because in that

[patch 1/5] Introduce __WARN()

2008-01-05 Thread Arjan van de Ven
From: Olof Johansson <[EMAIL PROTECTED]> Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> ---

[patch 1/5] Introduce __WARN()

2008-01-05 Thread Arjan van de Ven
From: Olof Johansson [EMAIL PROTECTED] Introduce __WARN() in the generic case, so the generic WARN_ON() can use arch-specific code for when the condition is true. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---