Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

On Tue, Jul 12, 2016 at 06:33:56PM +0200, Thomas Gleixner wrote: > Subject: sched/migration: Correct off by one in load migration > From: Thomas Gleixner > > The move of calc_load_migrate() from CPU_DEAD to CPU_DYING did not take into > account that the function is now

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

On Tue, Jul 12, 2016 at 06:33:56PM +0200, Thomas Gleixner wrote: > Subject: sched/migration: Correct off by one in load migration > From: Thomas Gleixner > > The move of calc_load_migrate() from CPU_DEAD to CPU_DYING did not take into > account that the function is now called from a thread

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

Hi, On 07/12/2016 10:03 PM, Thomas Gleixner wrote: > Anton, > > On Tue, 12 Jul 2016, Anton Blanchard wrote: >>> It really does not matter when we fold the load for the outgoing cpu. >>> It's almost dead anyway, so there is no harm if we fail to fold the >>> few microseconds which are required

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

Hi, On 07/12/2016 10:03 PM, Thomas Gleixner wrote: > Anton, > > On Tue, 12 Jul 2016, Anton Blanchard wrote: >>> It really does not matter when we fold the load for the outgoing cpu. >>> It's almost dead anyway, so there is no harm if we fail to fold the >>> few microseconds which are required

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

* Thomas Gleixner [2016-07-12 18:33:56]: > Anton, > > On Tue, 12 Jul 2016, Anton Blanchard wrote: > > > It really does not matter when we fold the load for the outgoing cpu. > > > It's almost dead anyway, so there is no harm if we fail to fold the > > > few microseconds

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

* Thomas Gleixner [2016-07-12 18:33:56]: > Anton, > > On Tue, 12 Jul 2016, Anton Blanchard wrote: > > > It really does not matter when we fold the load for the outgoing cpu. > > > It's almost dead anyway, so there is no harm if we fail to fold the > > > few microseconds which are required for

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

Anton, On Tue, 12 Jul 2016, Anton Blanchard wrote: > > It really does not matter when we fold the load for the outgoing cpu. > > It's almost dead anyway, so there is no harm if we fail to fold the > > few microseconds which are required for going fully away. > > We are seeing the load average

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

Anton, On Tue, 12 Jul 2016, Anton Blanchard wrote: > > It really does not matter when we fold the load for the outgoing cpu. > > It's almost dead anyway, so there is no harm if we fail to fold the > > few microseconds which are required for going fully away. > > We are seeing the load average

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

Hi Thomas, > It really does not matter when we fold the load for the outgoing cpu. > It's almost dead anyway, so there is no harm if we fail to fold the > few microseconds which are required for going fully away. We are seeing the load average shoot up when hot unplugging CPUs (+1 for every CPU

Re: [patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

Hi Thomas, > It really does not matter when we fold the load for the outgoing cpu. > It's almost dead anyway, so there is no harm if we fail to fold the > few microseconds which are required for going fully away. We are seeing the load average shoot up when hot unplugging CPUs (+1 for every CPU

[patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

It really does not matter when we fold the load for the outgoing cpu. It's almost dead anyway, so there is no harm if we fail to fold the few microseconds which are required for going fully away. Signed-off-by: Thomas Gleixner --- kernel/sched/core.c |3 --- 1 file

[patch 10/15] sched/migration: Move calc_load_migrate() into CPU_DYING

It really does not matter when we fold the load for the outgoing cpu. It's almost dead anyway, so there is no harm if we fail to fold the few microseconds which are required for going fully away. Signed-off-by: Thomas Gleixner --- kernel/sched/core.c |3 --- 1 file changed, 3 deletions(-)