Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-25 Thread Nick Piggin
Andrew Morton wrote: On Tue, 19 Jun 2007 15:38:01 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: Ok and BUILD_BUG_ON really works? Had some bad experiences with it. hm, I don't recall any problems, apart from its very obscure error reporting. But if it breaks, we get an

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-25 Thread Nick Piggin
Andrew Morton wrote: On Tue, 19 Jun 2007 15:38:01 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: Ok and BUILD_BUG_ON really works? Had some bad experiences with it. hm, I don't recall any problems, apart from its very obscure error reporting. But if it breaks, we get an

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:38:01 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Ok and BUILD_BUG_ON really works? Had some bad experiences with it. hm, I don't recall any problems, apart from its very obscure error reporting. But if it breaks, we get an opportunity to fix it ;) - To

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Christoph Lameter
On Tue, 19 Jun 2007, Andrew Morton wrote: > On Tue, 19 Jun 2007 15:22:36 -0700 (PDT) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > On Tue, 19 Jun 2007, Andrew Morton wrote: > > > > > On Mon, 18 Jun 2007 02:58:48 -0700 > > > [EMAIL PROTECTED] wrote: > > > > > > > +

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:22:36 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Tue, 19 Jun 2007, Andrew Morton wrote: > > > On Mon, 18 Jun 2007 02:58:48 -0700 > > [EMAIL PROTECTED] wrote: > > > > > + BUG_ON(KMALLOC_MIN_SIZE > 256 || > > > + (KMALLOC_MIN_SIZE &

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Christoph Lameter
On Tue, 19 Jun 2007, Andrew Morton wrote: > On Mon, 18 Jun 2007 02:58:48 -0700 > [EMAIL PROTECTED] wrote: > > > + BUG_ON(KMALLOC_MIN_SIZE > 256 || > > + (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1))); > > BUILD_BUG_ON? > Does not matter. That code is __init. - To unsubscribe from

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Mon, 18 Jun 2007 02:58:48 -0700 [EMAIL PROTECTED] wrote: > + BUG_ON(KMALLOC_MIN_SIZE > 256 || > + (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1))); BUILD_BUG_ON? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Mon, 18 Jun 2007 02:58:48 -0700 [EMAIL PROTECTED] wrote: + BUG_ON(KMALLOC_MIN_SIZE 256 || + (KMALLOC_MIN_SIZE (KMALLOC_MIN_SIZE - 1))); BUILD_BUG_ON? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Christoph Lameter
On Tue, 19 Jun 2007, Andrew Morton wrote: On Mon, 18 Jun 2007 02:58:48 -0700 [EMAIL PROTECTED] wrote: + BUG_ON(KMALLOC_MIN_SIZE 256 || + (KMALLOC_MIN_SIZE (KMALLOC_MIN_SIZE - 1))); BUILD_BUG_ON? Does not matter. That code is __init. - To unsubscribe from this list:

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:22:36 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 19 Jun 2007, Andrew Morton wrote: On Mon, 18 Jun 2007 02:58:48 -0700 [EMAIL PROTECTED] wrote: + BUG_ON(KMALLOC_MIN_SIZE 256 || + (KMALLOC_MIN_SIZE (KMALLOC_MIN_SIZE - 1)));

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Christoph Lameter
On Tue, 19 Jun 2007, Andrew Morton wrote: On Tue, 19 Jun 2007 15:22:36 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 19 Jun 2007, Andrew Morton wrote: On Mon, 18 Jun 2007 02:58:48 -0700 [EMAIL PROTECTED] wrote: + BUG_ON(KMALLOC_MIN_SIZE 256 || +

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:38:01 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: Ok and BUILD_BUG_ON really works? Had some bad experiences with it. hm, I don't recall any problems, apart from its very obscure error reporting. But if it breaks, we get an opportunity to fix it ;) - To

[patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-18 Thread clameter
kmalloc_index is a long series of comparisons. The attempt to replace kmalloc_index with something more efficient like ilog2 failed due to compiler issues with constant folding on gcc 3.3 / powerpc. kmalloc_index()'es long list of comparisons works fine for constant folding since all the

[patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-18 Thread clameter
kmalloc_index is a long series of comparisons. The attempt to replace kmalloc_index with something more efficient like ilog2 failed due to compiler issues with constant folding on gcc 3.3 / powerpc. kmalloc_index()'es long list of comparisons works fine for constant folding since all the