Re: [patch 11/12] usb: core: Replace in_interrupt() in comments

2020-10-14 Thread Alan Stern
On Wed, Oct 14, 2020 at 06:41:23PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-14 12:27:21 [-0400], Alan Stern wrote: > > > --- a/drivers/usb/core/hcd.c > > > +++ b/drivers/usb/core/hcd.c > > > @@ -746,9 +746,6 @@ static int rh_call_control (struct usb_h > > > * Root Hub interrupt

Re: [patch 11/12] usb: core: Replace in_interrupt() in comments

2020-10-14 Thread Sebastian Andrzej Siewior
On 2020-10-14 12:27:21 [-0400], Alan Stern wrote: > > --- a/drivers/usb/core/hcd.c > > +++ b/drivers/usb/core/hcd.c > > @@ -746,9 +746,6 @@ static int rh_call_control (struct usb_h > > * Root Hub interrupt transfers are polled using a timer if the > > * driver requests it; otherwise the driver

Re: [patch 11/12] usb: core: Replace in_interrupt() in comments

2020-10-14 Thread Alan Stern
On Wed, Oct 14, 2020 at 04:52:26PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for > functions which might sleep. That's wrong because

[patch 11/12] usb: core: Replace in_interrupt() in comments

2020-10-14 Thread Thomas Gleixner
From: Ahmed S. Darwish The usage of in_interrupt() in drivers is phased out for various reasons. Various comments use !in_interrupt() to describe calling context for functions which might sleep. That's wrong because the calling context has to be preemptible task context, which is not what