Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > I agree with that, but especially because this is not even the right > place to save and clear gs; when userspace uses an LDT based %gs, you > need to do this all the way back in mmu_context.h before you switch > the LDT out. Yeah. This patch was really just to shut my

Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Zachary Amsden
Andi Kleen wrote: /* +* Temporary hack: zero gs now that we've saved it so that Xen +* doesn't try to reload the old value after changing the GDT +* during the context switch. This can go away once Xen has +* been taught to only reload %gs when it

Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Keir Fraser
On 21/2/07 22:10, "Andi Kleen" <[EMAIL PROTECTED]> wrote: >> /* >> + * Temporary hack: zero gs now that we've saved it so that Xen >> + * doesn't try to reload the old value after changing the GDT >> + * during the context switch. This can go away once Xen has >> + * been taught to only

Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > Sorry, but i don't really want that unconditionally in the context switch. > Adding a paravirt ops for it would be also ugly. Can Xen be fixed? > Yes. I'm happy to drop this one. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Andi Kleen
> /* > + * Temporary hack: zero gs now that we've saved it so that Xen > + * doesn't try to reload the old value after changing the GDT > + * during the context switch. This can go away once Xen has > + * been taught to only reload %gs when it absolutely must. > +

Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Andi Kleen
/* + * Temporary hack: zero gs now that we've saved it so that Xen + * doesn't try to reload the old value after changing the GDT + * during the context switch. This can go away once Xen has + * been taught to only reload %gs when it absolutely must. + */ +

Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Jeremy Fitzhardinge
Andi Kleen wrote: Sorry, but i don't really want that unconditionally in the context switch. Adding a paravirt ops for it would be also ugly. Can Xen be fixed? Yes. I'm happy to drop this one. J - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Keir Fraser
On 21/2/07 22:10, Andi Kleen [EMAIL PROTECTED] wrote: /* + * Temporary hack: zero gs now that we've saved it so that Xen + * doesn't try to reload the old value after changing the GDT + * during the context switch. This can go away once Xen has + * been taught to only reload %gs when it

Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Zachary Amsden
Andi Kleen wrote: /* +* Temporary hack: zero gs now that we've saved it so that Xen +* doesn't try to reload the old value after changing the GDT +* during the context switch. This can go away once Xen has +* been taught to only reload %gs when it

Re: [Xen-devel] Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

2007-02-21 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: I agree with that, but especially because this is not even the right place to save and clear gs; when userspace uses an LDT based %gs, you need to do this all the way back in mmu_context.h before you switch the LDT out. Yeah. This patch was really just to shut my debug