Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Heiko Carstens
On Fri, Jan 04, 2008 at 06:50:42AM -0800, Arjan van de Ven wrote: > Heiko Carstens wrote: >> On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: >>> Another issue is that, unlike oopses, WARN_ON() doesn't currently printk >>> the helpful "cut here" line, nor the "end of trace"

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Arjan van de Ven
Heiko Carstens wrote: On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: Another issue is that, unlike oopses, WARN_ON() doesn't currently printk the helpful "cut here" line, nor the "end of trace" marker. Now that WARN_ON() is out of line, the size increase due to this is

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Heiko Carstens
On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: > > Another issue is that, unlike oopses, WARN_ON() doesn't currently printk > the helpful "cut here" line, nor the "end of trace" marker. > Now that WARN_ON() is out of line, the size increase due to this is > minimal and it's

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Ingo Molnar
* Arjan van de Ven <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: >> * Arjan van de Ven <[EMAIL PROTECTED]> wrote: >> >>> + printk(KERN_WARNING "[ cut here ]\n"); >>> printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file, >>> line, function); >>> +

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Arjan van de Ven
Ingo Molnar wrote: * Arjan van de Ven <[EMAIL PROTECTED]> wrote: + printk(KERN_WARNING "[ cut here ]\n"); printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file, line, function); + print_modules(); dump_stack(); +

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Heiko Carstens
On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: Another issue is that, unlike oopses, WARN_ON() doesn't currently printk the helpful cut here line, nor the end of trace marker. Now that WARN_ON() is out of line, the size increase due to this is minimal and it's worth adding.

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Ingo Molnar
* Arjan van de Ven [EMAIL PROTECTED] wrote: Ingo Molnar wrote: * Arjan van de Ven [EMAIL PROTECTED] wrote: + printk(KERN_WARNING [ cut here ]\n); printk(KERN_WARNING WARNING: at %s:%d %s()\n, file, line, function); + print_modules();

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Arjan van de Ven
Ingo Molnar wrote: * Arjan van de Ven [EMAIL PROTECTED] wrote: + printk(KERN_WARNING [ cut here ]\n); printk(KERN_WARNING WARNING: at %s:%d %s()\n, file, line, function); + print_modules(); dump_stack(); +

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Arjan van de Ven
Heiko Carstens wrote: On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: Another issue is that, unlike oopses, WARN_ON() doesn't currently printk the helpful cut here line, nor the end of trace marker. Now that WARN_ON() is out of line, the size increase due to this is minimal

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-04 Thread Heiko Carstens
On Fri, Jan 04, 2008 at 06:50:42AM -0800, Arjan van de Ven wrote: Heiko Carstens wrote: On Thu, Jan 03, 2008 at 10:27:28PM +0100, Arjan van de Ven wrote: Another issue is that, unlike oopses, WARN_ON() doesn't currently printk the helpful cut here line, nor the end of trace marker. Now that

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven <[EMAIL PROTECTED]> wrote: > + printk(KERN_WARNING "[ cut here ]\n"); > printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file, > line, function); > + print_modules(); > dump_stack(); > + print_oops_end_marker();

[patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-03 Thread Arjan van de Ven
Subject: Add the end-of-trace marker and the module list to WARN_ON() From: Arjan van de Ven <[EMAIL PROTECTED]> CC: Ingo Molnar <[EMAIL PROTECTED]> CC: Andrew Morton <[EMAIL PROTECTED]> CC: Olof Johansson <[EMAIL PROTECTED]> Unlike oopses, WARN_ON() currently doesn't print the loaded modules

[patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-03 Thread Arjan van de Ven
Subject: Add the end-of-trace marker and the module list to WARN_ON() From: Arjan van de Ven [EMAIL PROTECTED] CC: Ingo Molnar [EMAIL PROTECTED] CC: Andrew Morton [EMAIL PROTECTED] CC: Olof Johansson [EMAIL PROTECTED] Unlike oopses, WARN_ON() currently doesn't print the loaded modules list. This

Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()

2008-01-03 Thread Ingo Molnar
* Arjan van de Ven [EMAIL PROTECTED] wrote: + printk(KERN_WARNING [ cut here ]\n); printk(KERN_WARNING WARNING: at %s:%d %s()\n, file, line, function); + print_modules(); dump_stack(); + print_oops_end_marker(); another thing: