Re: [patch 2/3] hd eliminate bad section references

2005-04-04 Thread Rusty Russell
On Tue, 2005-04-05 at 01:05 +0200, maximilian attems wrote: > On Mon, 04 Apr 2005, Randy.Dunlap wrote: > > Rusty, can you explain when __setup functions are called relative > > to in-kernel init functions? or put another way, can a __setup > > function safely call in __init function? Yes. init

Re: [patch 2/3] hd eliminate bad section references

2005-04-04 Thread maximilian attems
On Mon, 04 Apr 2005, Randy.Dunlap wrote: > >-static int parse_hd_setup (char *line) { > >+static int __init parse_hd_setup (char *line) { .. > This one is fairly interesting and needs some resolution by someone > who knows thanks a lot for your quick and profund feedback. > On the

Re: [patch 2/3] hd eliminate bad section references

2005-04-04 Thread Randy.Dunlap
maximilian attems wrote: Fix hd section references: make parse_hd_setup() __init Error: ./drivers/ide/legacy/hd.o .text refers to 0943 R_386_PC32 .init.text Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-bk5/drivers/ide/legacy/hd.c.orig 2005-04-04 18:39:04.0

[patch 2/3] hd eliminate bad section references

2005-04-04 Thread maximilian attems
Fix hd section references: make parse_hd_setup() __init Error: ./drivers/ide/legacy/hd.o .text refers to 0943 R_386_PC32 .init.text Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-bk5/drivers/ide/legacy/hd.c.orig 2005-04-04 18:39:04.0 +0200 +++

[patch 2/3] hd eliminate bad section references

2005-04-04 Thread maximilian attems
Fix hd section references: make parse_hd_setup() __init Error: ./drivers/ide/legacy/hd.o .text refers to 0943 R_386_PC32 .init.text Signed-off-by: maximilian attems [EMAIL PROTECTED] --- linux-2.6.12-rc1-bk5/drivers/ide/legacy/hd.c.orig 2005-04-04 18:39:04.0 +0200 +++

Re: [patch 2/3] hd eliminate bad section references

2005-04-04 Thread Randy.Dunlap
maximilian attems wrote: Fix hd section references: make parse_hd_setup() __init Error: ./drivers/ide/legacy/hd.o .text refers to 0943 R_386_PC32 .init.text Signed-off-by: maximilian attems [EMAIL PROTECTED] --- linux-2.6.12-rc1-bk5/drivers/ide/legacy/hd.c.orig 2005-04-04 18:39:04.0

Re: [patch 2/3] hd eliminate bad section references

2005-04-04 Thread maximilian attems
On Mon, 04 Apr 2005, Randy.Dunlap wrote: -static int parse_hd_setup (char *line) { +static int __init parse_hd_setup (char *line) { .. This one is fairly interesting and needs some resolution by someone who knows thanks a lot for your quick and profund feedback. On the surface, the

Re: [patch 2/3] hd eliminate bad section references

2005-04-04 Thread Rusty Russell
On Tue, 2005-04-05 at 01:05 +0200, maximilian attems wrote: On Mon, 04 Apr 2005, Randy.Dunlap wrote: Rusty, can you explain when __setup functions are called relative to in-kernel init functions? or put another way, can a __setup function safely call in __init function? Yes. init