Re: [patch 2/5] Linux Kernel Markers

2007-09-29 Thread Rusty Russell
On Fri, 2007-09-28 at 10:28 -0400, Mathieu Desnoyers wrote: > +struct __mark_marker; Hi Mathieu, How about, "struct marker". You've taken the "marker*" namespace, so all these underscores are __gratuitious__ :) > +/* > + * module_mutex nests inside markers_mutex. Markers mutex protects

Re: [patch 2/5] Linux Kernel Markers

2007-09-29 Thread Rusty Russell
On Fri, 2007-09-28 at 10:28 -0400, Mathieu Desnoyers wrote: +struct __mark_marker; Hi Mathieu, How about, struct marker. You've taken the marker* namespace, so all these underscores are __gratuitious__ :) +/* + * module_mutex nests inside markers_mutex. Markers mutex protects the

[patch 2/5] Linux Kernel Markers

2007-09-28 Thread Mathieu Desnoyers
The marker activation functions sits in kernel/marker.c. A hash table is used to keep track of the registered probes and armed markers, so the markers within a newly loaded module that should be active can be activated at module load time. marker_query has been removed. marker_get_first,

[patch 2/5] Linux Kernel Markers

2007-09-28 Thread Mathieu Desnoyers
The marker activation functions sits in kernel/marker.c. A hash table is used to keep track of the registered probes and armed markers, so the markers within a newly loaded module that should be active can be activated at module load time. marker_query has been removed. marker_get_first,

[patch 2/5] Linux Kernel Markers

2007-09-25 Thread Mathieu Desnoyers
The marker activation functions sits in kernel/marker.c. A hash table is used to keep track of the registered probes and armed markers, so the markers within a newly loaded module that should be active can be activated at module load time. marker_query has been removed. marker_get_first,

[patch 2/5] Linux Kernel Markers

2007-09-25 Thread Mathieu Desnoyers
The marker activation functions sits in kernel/marker.c. A hash table is used to keep track of the registered probes and armed markers, so the markers within a newly loaded module that should be active can be activated at module load time. marker_query has been removed. marker_get_first,

[patch 2/5] Linux Kernel Markers, architecture independent code.

2007-06-15 Thread Mathieu Desnoyers
The marker activation functions sits in kernel/marker.c. A linked list is used to keep track of the armed/disarmed markers, so they can be activated at module load time. Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> --- include/asm-generic/vmlinux.lds.h | 11 include/linux/marker.h

[patch 2/5] Linux Kernel Markers, architecture independent code.

2007-06-15 Thread Mathieu Desnoyers
The marker activation functions sits in kernel/marker.c. A linked list is used to keep track of the armed/disarmed markers, so they can be activated at module load time. Signed-off-by: Mathieu Desnoyers [EMAIL PROTECTED] --- include/asm-generic/vmlinux.lds.h | 11 include/linux/marker.h