Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-19 Thread Chris Wright
* Eric W. Biederman ([EMAIL PROTECTED]) wrote: > Chris Wright <[EMAIL PROTECTED]> writes: > > > * Ingo Molnar ([EMAIL PROTECTED]) wrote: > >> > ENTRY(swapper_pg_dir) > >> > +.align PAGE_SIZE_asm > >> > .fill 1024,4,0 > >> > >> does the native kernel lose memory here? > > > >

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-19 Thread Jeremy Fitzhardinge
Eric W. Biederman wrote: ENTRY(swapper_pg_dir) + .align PAGE_SIZE_asm .fill 1024,4,0 >>> > Shouldn't the align be before the label. Otherwise padding > would be inserted between the label and the data. Good point. Thanks, J - To unsubscribe from this list:

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-19 Thread Eric W. Biederman
Chris Wright <[EMAIL PROTECTED]> writes: > * Ingo Molnar ([EMAIL PROTECTED]) wrote: >> > ENTRY(swapper_pg_dir) >> > + .align PAGE_SIZE_asm >> >.fill 1024,4,0 >> >> does the native kernel lose memory here? > > Not in my builds. Shouldn't the align be before the label. Otherwise padding

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-19 Thread Eric W. Biederman
Chris Wright [EMAIL PROTECTED] writes: * Ingo Molnar ([EMAIL PROTECTED]) wrote: ENTRY(swapper_pg_dir) + .align PAGE_SIZE_asm .fill 1024,4,0 does the native kernel lose memory here? Not in my builds. Shouldn't the align be before the label. Otherwise padding would be inserted

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-19 Thread Jeremy Fitzhardinge
Eric W. Biederman wrote: ENTRY(swapper_pg_dir) + .align PAGE_SIZE_asm .fill 1024,4,0 Shouldn't the align be before the label. Otherwise padding would be inserted between the label and the data. Good point. Thanks, J - To unsubscribe from this list: send the line

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-19 Thread Chris Wright
* Eric W. Biederman ([EMAIL PROTECTED]) wrote: Chris Wright [EMAIL PROTECTED] writes: * Ingo Molnar ([EMAIL PROTECTED]) wrote: ENTRY(swapper_pg_dir) +.align PAGE_SIZE_asm .fill 1024,4,0 does the native kernel lose memory here? Not in my builds. Shouldn't

Re: [Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-18 Thread Jeremy Fitzhardinge
Rusty Russell wrote: > On Fri, 2007-03-16 at 10:14 +0100, Ingo Molnar wrote: > >>> +unsigned long xen_pmd_val(pmd_t pmd) >>> +{ >>> + BUG(); >>> + return 0; >>> +} >>> >> make it noret. >> > > OK, I missed this one. How? > > Wondering if I've missed a trick here... No, I don't

Re: [Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-18 Thread Jeremy Fitzhardinge
Rusty Russell wrote: On Fri, 2007-03-16 at 10:14 +0100, Ingo Molnar wrote: +unsigned long xen_pmd_val(pmd_t pmd) +{ + BUG(); + return 0; +} make it noret. OK, I missed this one. How? Wondering if I've missed a trick here... No, I don't think its terribly useful

Re: [Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 10:14 +0100, Ingo Molnar wrote: > > +unsigned long xen_pmd_val(pmd_t pmd) > > +{ > > + BUG(); > > + return 0; > > +} > > make it noret. OK, I missed this one. How? Wondering if I've missed a trick here... Rusty. - To unsubscribe from this list: send the line

Re: [Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-17 Thread Rusty Russell
On Fri, 2007-03-16 at 10:14 +0100, Ingo Molnar wrote: +unsigned long xen_pmd_val(pmd_t pmd) +{ + BUG(); + return 0; +} make it noret. OK, I missed this one. How? Wondering if I've missed a trick here... Rusty. - To unsubscribe from this list: send the line unsubscribe

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > > ENTRY(swapper_pg_dir) > > + .align PAGE_SIZE_asm > > .fill 1024,4,0 > > does the native kernel lose memory here? Not in my builds. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: > Chris Wright wrote: > > That's been fixed, the two are built as seperate objects now. > > Actually, we tried it but it causes bad kernel images with some > binutils, so it has to be included for now. Ah, missed that. > >>> @@ -437,9 +437,9 @@

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Jeremy Fitzhardinge
Chris Wright wrote: > * Ingo Molnar ([EMAIL PROTECTED]) wrote: > >> * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: >> >> >>> Core Xen Implementation >>> >>> This patch is a rollup of all the core pieces of the Xen >>> implementation, including booting, memory management, interrupts,

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Core Xen Implementation > > > > This patch is a rollup of all the core pieces of the Xen > > implementation, including booting, memory management, interrupts, time > > and so on. > > > ---

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Christoph Hellwig
On Fri, Mar 16, 2007 at 10:14:11AM +0100, Ingo Molnar wrote: > > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Core Xen Implementation > > > > This patch is a rollup of all the core pieces of the Xen > > implementation, including booting, memory management, interrupts, time > > and

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Core Xen Implementation > > This patch is a rollup of all the core pieces of the Xen > implementation, including booting, memory management, interrupts, time > and so on. > --- a/arch/i386/kernel/head.S > +++ b/arch/i386/kernel/head.S > @@

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Ingo Molnar
* Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Core Xen Implementation This patch is a rollup of all the core pieces of the Xen implementation, including booting, memory management, interrupts, time and so on. --- a/arch/i386/kernel/head.S +++ b/arch/i386/kernel/head.S @@ -535,6

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Christoph Hellwig
On Fri, Mar 16, 2007 at 10:14:11AM +0100, Ingo Molnar wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Core Xen Implementation This patch is a rollup of all the core pieces of the Xen implementation, including booting, memory management, interrupts, time and so on. ---

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Core Xen Implementation This patch is a rollup of all the core pieces of the Xen implementation, including booting, memory management, interrupts, time and so on. ---

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Jeremy Fitzhardinge
Chris Wright wrote: * Ingo Molnar ([EMAIL PROTECTED]) wrote: * Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: Core Xen Implementation This patch is a rollup of all the core pieces of the Xen implementation, including booting, memory management, interrupts, time and so on.

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Chris Wright
* Jeremy Fitzhardinge ([EMAIL PROTECTED]) wrote: Chris Wright wrote: That's been fixed, the two are built as seperate objects now. Actually, we tried it but it causes bad kernel images with some binutils, so it has to be included for now. Ah, missed that. @@ -437,9 +437,9 @@ static

Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation

2007-03-16 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: ENTRY(swapper_pg_dir) + .align PAGE_SIZE_asm .fill 1024,4,0 does the native kernel lose memory here? Not in my builds. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]