Re: [patch 27/32] xen: Add the Xen virtual network device driver.

2007-04-30 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: > On Sun, Apr 29, 2007 at 10:29:02AM -0700, Jeremy Fitzhardinge wrote: > >> +#include >> > > not needed. > Yup. >> +#include >> +#include >> +#include >> +#ifdef CONFIG_XEN_BALLOON >> +#include >> +#endif >> +#include >> > > Please don't try to put

Re: [patch 27/32] xen: Add the Xen virtual network device driver.

2007-04-30 Thread Jeremy Fitzhardinge
Christoph Hellwig wrote: On Sun, Apr 29, 2007 at 10:29:02AM -0700, Jeremy Fitzhardinge wrote: +#include linux/version.h not needed. Yup. +#include xen/xenbus.h +#include xen/interface/io/netif.h +#include xen/interface/memory.h +#ifdef CONFIG_XEN_BALLOON +#include

Re: [patch 27/32] xen: Add the Xen virtual network device driver.

2007-04-29 Thread Christoph Hellwig
On Sun, Apr 29, 2007 at 10:29:02AM -0700, Jeremy Fitzhardinge wrote: > +#include not needed. > +#include > +#include > +#include > +#ifdef CONFIG_XEN_BALLOON > +#include > +#endif > +#include Please don't try to put such a fucked up include hierachy in. Just move everything under

[patch 27/32] xen: Add the Xen virtual network device driver.

2007-04-29 Thread Jeremy Fitzhardinge
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt <[EMAIL PROTECTED]> Signed-off-by: Christian Limpach <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL

[patch 27/32] xen: Add the Xen virtual network device driver.

2007-04-29 Thread Jeremy Fitzhardinge
The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt [EMAIL PROTECTED] Signed-off-by: Christian Limpach [EMAIL PROTECTED] Signed-off-by: Chris Wright [EMAIL

Re: [patch 27/32] xen: Add the Xen virtual network device driver.

2007-04-29 Thread Christoph Hellwig
On Sun, Apr 29, 2007 at 10:29:02AM -0700, Jeremy Fitzhardinge wrote: +#include linux/version.h not needed. +#include xen/xenbus.h +#include xen/interface/io/netif.h +#include xen/interface/memory.h +#ifdef CONFIG_XEN_BALLOON +#include xen/balloon.h +#endif +#include