Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode (try3)

2007-07-02 Thread David Chinner
On Mon, Jul 02, 2007 at 05:05:09PM +0200, Michal Marek wrote: > On Mon, Jul 02, 2007 at 11:40:34AM +0200, Michal Marek wrote: > > David Chinner wrote: > > > I think we can remove xfs_bulkstat_one_compat() completely by using > > > the same method you used with the xfs_inumber_fmt functions. > > >

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode (try3)

2007-07-02 Thread Michal Marek
On Mon, Jul 02, 2007 at 11:40:34AM +0200, Michal Marek wrote: > David Chinner wrote: > > I think we can remove xfs_bulkstat_one_compat() completely by using > > the same method you used with the xfs_inumber_fmt functions. > > You mean xfs_ioc_bulkstat_compat() -> native xfs_bulkstat() -> native >

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-07-02 Thread Michal Marek
David Chinner wrote: > On Tue, Jun 19, 2007 at 03:25:52PM +0200, [EMAIL PROTECTED] wrote: >> +static int xfs_bulkstat_one_compat( >> +xfs_mount_t *mp,/* mount point for filesystem */ >> +xfs_ino_t ino,/* inode number to get data for */ >> +void

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-07-02 Thread Michal Marek
David Chinner wrote: On Tue, Jun 19, 2007 at 03:25:52PM +0200, [EMAIL PROTECTED] wrote: +static int xfs_bulkstat_one_compat( +xfs_mount_t *mp,/* mount point for filesystem */ +xfs_ino_t ino,/* inode number to get data for */ +void

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode (try3)

2007-07-02 Thread Michal Marek
On Mon, Jul 02, 2007 at 11:40:34AM +0200, Michal Marek wrote: David Chinner wrote: I think we can remove xfs_bulkstat_one_compat() completely by using the same method you used with the xfs_inumber_fmt functions. You mean xfs_ioc_bulkstat_compat() - native xfs_bulkstat() - native

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode (try3)

2007-07-02 Thread David Chinner
On Mon, Jul 02, 2007 at 05:05:09PM +0200, Michal Marek wrote: On Mon, Jul 02, 2007 at 11:40:34AM +0200, Michal Marek wrote: David Chinner wrote: I think we can remove xfs_bulkstat_one_compat() completely by using the same method you used with the xfs_inumber_fmt functions. You mean

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-29 Thread Michal Marek
On Thu, Jun 28, 2007 at 11:15:30AM -0700, Andrew Morton wrote: > CC fs/xfs/linux-2.6/xfs_ioctl32.o > fs/xfs/linux-2.6/xfs_ioctl32.c: In function ‘xfs_ioc_bulkstat_compat’: > fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: ‘xfs_inumbers_fmt_compat’ > undeclared (first use in this function) >

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-29 Thread Michal Marek
On Thu, Jun 28, 2007 at 11:15:30AM -0700, Andrew Morton wrote: CC fs/xfs/linux-2.6/xfs_ioctl32.o fs/xfs/linux-2.6/xfs_ioctl32.c: In function ‘xfs_ioc_bulkstat_compat’: fs/xfs/linux-2.6/xfs_ioctl32.c:334: error: ‘xfs_inumbers_fmt_compat’ undeclared (first use in this function)

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-28 Thread Andrew Morton
On Tue, 19 Jun 2007 15:25:52 +0200 [EMAIL PROTECTED] wrote: > * 32bit struct xfs_fsop_bulkreq has different size and layout of > members, no matter the alignment. Move the code out of the #else > branch (why was it there in the first place?). Define _32 variants of > the ioctl constants. >

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-28 Thread Andrew Morton
On Tue, 19 Jun 2007 15:25:52 +0200 [EMAIL PROTECTED] wrote: * 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants. *

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-27 Thread David Chinner
On Tue, Jun 19, 2007 at 03:25:52PM +0200, [EMAIL PROTECTED] wrote: > * 32bit struct xfs_fsop_bulkreq has different size and layout of > members, no matter the alignment. Move the code out of the #else > branch (why was it there in the first place?). Define _32 variants of > the ioctl

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-27 Thread David Chinner
On Tue, Jun 19, 2007 at 03:25:52PM +0200, [EMAIL PROTECTED] wrote: * 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants.

[patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-19 Thread mmarek
* 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants. * 32bit struct xfs_bstat is different because of time_t and on i386

[patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-06-19 Thread mmarek
* 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants. * 32bit struct xfs_bstat is different because of time_t and on i386

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread David Chinner
On Thu, May 31, 2007 at 10:52:14AM +0200, Michal Marek wrote: > David Chinner wrote: > > On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: > >> +typedef struct xfs_bstat32 { ... > >> +} > >> +#ifdef BROKEN_X86_ALIGNMENT > >> + __attribute__((packed)) > >> +#endif > >> +

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread Michal Marek
David Chinner wrote: > On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: >> +typedef struct xfs_bstat32 { >> +__u64 bs_ino; /* inode number */ >> +__u16 bs_mode;/* type and mode*/ >> +__u16

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread Arnd Bergmann
On Wednesday 30 May 2007, Michal Marek wrote: > --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c > +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c > @@ -109,35 +109,249 @@ STATIC unsigned long xfs_ioctl32_geom_v1 > return (unsigned long)p; > } > > -#else > +typedef struct xfs_inogrp32 { > +

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread David Chinner
On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: > * 32bit struct xfs_fsop_bulkreq has different size and layout of > members, no matter the alignment. Move the code out of the #else > branch (why was it there in the first place?). Define _32 variants of > the ioctl constants. >

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread David Chinner
On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: * 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants. *

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread Arnd Bergmann
On Wednesday 30 May 2007, Michal Marek wrote: --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c @@ -109,35 +109,249 @@ STATIC unsigned long xfs_ioctl32_geom_v1 return (unsigned long)p; } -#else +typedef struct xfs_inogrp32 { +

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread Michal Marek
David Chinner wrote: On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: +typedef struct xfs_bstat32 { +__u64 bs_ino; /* inode number */ +__u16 bs_mode;/* type and mode*/ +__u16 bs_nlink;

Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-31 Thread David Chinner
On Thu, May 31, 2007 at 10:52:14AM +0200, Michal Marek wrote: David Chinner wrote: On Wed, May 30, 2007 at 02:59:57PM +0200, Michal Marek wrote: +typedef struct xfs_bstat32 { ... +} +#ifdef BROKEN_X86_ALIGNMENT + __attribute__((packed)) +#endif + xfs_bstat32_t; #ifdef

[patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-30 Thread Michal Marek
* 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants. * 32bit struct xfs_bstat is different on 32bit (because of time_t and

[patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode

2007-05-30 Thread Michal Marek
* 32bit struct xfs_fsop_bulkreq has different size and layout of members, no matter the alignment. Move the code out of the #else branch (why was it there in the first place?). Define _32 variants of the ioctl constants. * 32bit struct xfs_bstat is different on 32bit (because of time_t and