Re: [patch 3/3] update ctime and mtime for mmaped write

2007-03-25 Thread Miklos Szeredi
> A few comments.. Thanks for reviewing. > > Index: linux-2.6.21-rc4-mm1/mm/rmap.c > > === > > --- linux-2.6.21-rc4-mm1.orig/mm/rmap.c 2007-03-24 19:03:11.0 > > +0100 > > +++ linux-2.6.21-rc4-mm1/mm/rmap.c 2007-03-24

Re: [patch 3/3] update ctime and mtime for mmaped write

2007-03-25 Thread Peter Zijlstra
On Sat, 2007-03-24 at 23:11 +0100, Miklos Szeredi wrote: > From: Miklos Szeredi <[EMAIL PROTECTED]> > > Changes: > v3: > o rename is_page_modified to test_clear_page_modified > v2: > o set AS_CMTIME flag in clear_page_dirty_for_io() too > o don't clear AS_CMTIME in file_update_time() > o

Re: [patch 3/3] update ctime and mtime for mmaped write

2007-03-25 Thread Peter Zijlstra
On Sat, 2007-03-24 at 23:11 +0100, Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Changes: v3: o rename is_page_modified to test_clear_page_modified v2: o set AS_CMTIME flag in clear_page_dirty_for_io() too o don't clear AS_CMTIME in file_update_time() o check the dirty

Re: [patch 3/3] update ctime and mtime for mmaped write

2007-03-25 Thread Miklos Szeredi
A few comments.. Thanks for reviewing. Index: linux-2.6.21-rc4-mm1/mm/rmap.c === --- linux-2.6.21-rc4-mm1.orig/mm/rmap.c 2007-03-24 19:03:11.0 +0100 +++ linux-2.6.21-rc4-mm1/mm/rmap.c 2007-03-24

[patch 3/3] update ctime and mtime for mmaped write

2007-03-24 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Changes: v3: o rename is_page_modified to test_clear_page_modified v2: o set AS_CMTIME flag in clear_page_dirty_for_io() too o don't clear AS_CMTIME in file_update_time() o check the dirty bit in the page tables v1: o moved check from __fput() to

[patch 3/3] update ctime and mtime for mmaped write

2007-03-24 Thread Miklos Szeredi
From: Miklos Szeredi [EMAIL PROTECTED] Changes: v3: o rename is_page_modified to test_clear_page_modified v2: o set AS_CMTIME flag in clear_page_dirty_for_io() too o don't clear AS_CMTIME in file_update_time() o check the dirty bit in the page tables v1: o moved check from __fput() to