Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-12 Thread Michal Hocko
On Wed 12-03-14 10:53:00, Johannes Weiner wrote: > On Wed, Mar 12, 2014 at 01:52:13PM +0100, Michal Hocko wrote: > > On Tue 11-03-14 21:28:29, Johannes Weiner wrote: > > [...] > > > @@ -3919,20 +3919,21 @@ out: > > > return ret; > > > } > > > > > > -/* > > > - * Charge the memory controller

Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-12 Thread Johannes Weiner
On Wed, Mar 12, 2014 at 01:52:13PM +0100, Michal Hocko wrote: > On Tue 11-03-14 21:28:29, Johannes Weiner wrote: > [...] > > @@ -3919,20 +3919,21 @@ out: > > return ret; > > } > > > > -/* > > - * Charge the memory controller for page usage. > > - * Return > > - * 0 if the charge was

Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-12 Thread Michal Hocko
On Tue 11-03-14 21:28:29, Johannes Weiner wrote: [...] > @@ -3919,20 +3919,21 @@ out: > return ret; > } > > -/* > - * Charge the memory controller for page usage. > - * Return > - * 0 if the charge was successful > - * < 0 if the cgroup is over its limit > - */ > -static int

Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-12 Thread Johannes Weiner
On Wed, Mar 12, 2014 at 01:52:13PM +0100, Michal Hocko wrote: On Tue 11-03-14 21:28:29, Johannes Weiner wrote: [...] @@ -3919,20 +3919,21 @@ out: return ret; } -/* - * Charge the memory controller for page usage. - * Return - * 0 if the charge was successful - * 0 if

Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-12 Thread Michal Hocko
On Wed 12-03-14 10:53:00, Johannes Weiner wrote: On Wed, Mar 12, 2014 at 01:52:13PM +0100, Michal Hocko wrote: On Tue 11-03-14 21:28:29, Johannes Weiner wrote: [...] @@ -3919,20 +3919,21 @@ out: return ret; } -/* - * Charge the memory controller for page usage. - *

Re: [patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-12 Thread Michal Hocko
On Tue 11-03-14 21:28:29, Johannes Weiner wrote: [...] @@ -3919,20 +3919,21 @@ out: return ret; } -/* - * Charge the memory controller for page usage. - * Return - * 0 if the charge was successful - * 0 if the cgroup is over its limit - */ -static int

[patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-11 Thread Johannes Weiner
mem_cgroup_charge_common() is used by both cache and anon pages, but most of its body only applies to anon pages and the remainder is not worth having in a separate function. Signed-off-by: Johannes Weiner --- mm/memcontrol.c | 40 1 file changed, 16

[patch 3/8] mm: memcg: inline mem_cgroup_charge_common()

2014-03-11 Thread Johannes Weiner
mem_cgroup_charge_common() is used by both cache and anon pages, but most of its body only applies to anon pages and the remainder is not worth having in a separate function. Signed-off-by: Johannes Weiner han...@cmpxchg.org --- mm/memcontrol.c | 40 1