Re: [patch v7 05/21] sched: log the cpu utilization at rq

2013-05-06 Thread Paul Turner
On Wed, Apr 3, 2013 at 7:00 PM, Alex Shi wrote: > The cpu's utilization is to measure how busy is the cpu. > util = cpu_rq(cpu)->avg.runnable_avg_sum * SCHED_POEWR_SCALE > / cpu_rq(cpu)->avg.runnable_avg_period; > > Since the util is no more than 1, we scale its value with

Re: [patch v7 05/21] sched: log the cpu utilization at rq

2013-05-06 Thread Alex Shi
On 05/06/2013 08:03 PM, Phil Carmody wrote: >> > + period = rq->avg.runnable_avg_period ? rq->avg.runnable_avg_period : >> > 1; >> > + rq->util = (u64)(rq->avg.runnable_avg_sum << SCHED_POWER_SHIFT) >> > + / period; > Greetings, Alex. > > That cast achieves not

Re: [patch v7 05/21] sched: log the cpu utilization at rq

2013-05-06 Thread Phil Carmody
[Apologies if threading mangled, all headers written by hand] On 04/04/2013 07:30 AM, Alex Shi wrote: > The cpu's utilization is to measure how busy is the cpu. > util = cpu_rq(cpu)->avg.runnable_avg_sum * SCHED_POEWR_SCALE > / cpu_rq(cpu)->avg.runnable_avg_period; > > Sin

Re: [patch v7 05/21] sched: log the cpu utilization at rq

2013-05-05 Thread Alex Shi
On 05/06/2013 11:26 AM, Preeti U Murthy wrote: > Hi Alex, > > You can add my Reviewed-by for the below patch. > > Thanks Thanks a lot for the review! -- Thanks Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.

Re: [patch v7 05/21] sched: log the cpu utilization at rq

2013-05-05 Thread Preeti U Murthy
Hi Alex, You can add my Reviewed-by for the below patch. Thanks Regards Preeti U Murthy On 04/04/2013 07:30 AM, Alex Shi wrote: > The cpu's utilization is to measure how busy is the cpu. > util = cpu_rq(cpu)->avg.runnable_avg_sum * SCHED_POEWR_SCALE > / cpu_rq(cpu)->avg.

[patch v7 05/21] sched: log the cpu utilization at rq

2013-04-03 Thread Alex Shi
The cpu's utilization is to measure how busy is the cpu. util = cpu_rq(cpu)->avg.runnable_avg_sum * SCHED_POEWR_SCALE / cpu_rq(cpu)->avg.runnable_avg_period; Since the util is no more than 1, we scale its value with 1024, same as SCHED_POWER_SCALE and set the FULL_UTIL as 1