Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-19 Thread Paul E. McKenney
On Fri, Mar 19, 2021 at 11:15:42PM +0900, Tetsuo Handa wrote: > On 2021/03/12 0:54, Marco Elver wrote: > >> But the more we could have the compiler automatically figure out > >> things without needing an explicit tag, it would seem to me that this > >> would be better, since manual tagging is going

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-19 Thread Tetsuo Handa
On 2021/03/12 0:54, Marco Elver wrote: >> But the more we could have the compiler automatically figure out >> things without needing an explicit tag, it would seem to me that this >> would be better, since manual tagging is going to be more error-prone. > > What you're alluding to here would go mu

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-11 Thread Marco Elver
+Cc Paul On Thu, 11 Mar 2021 at 16:30, Theodore Ts'o wrote: > > On Thu, Mar 11, 2021 at 04:08:30PM +0100, Marco Elver wrote: > > If the outcome of the check does not affect correctness and the code is > > entirely fault tolerant to the precise value being read, then a > > data_race(!journal->j_ru

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-11 Thread Theodore Ts'o
On Thu, Mar 11, 2021 at 04:08:30PM +0100, Marco Elver wrote: > If the outcome of the check does not affect correctness and the code is > entirely fault tolerant to the precise value being read, then a > data_race(!journal->j_running_transaction) marking here would be fine. So a very common coding

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-11 Thread Marco Elver
On Thu, Mar 11, 2021 at 03:53PM +0100, Dmitry Vyukov wrote: > On Thu, Mar 11, 2021 at 3:25 PM Jan Kara wrote: > > > > On Thu 11-03-21 02:59:14, syzbot wrote: > > > HEAD commit:a74e6a01 Merge tag 's390-5.12-3' of > > > git://git.kernel.org/p.. > > > git tree: upstream > > > console outpu

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-11 Thread Dmitry Vyukov
On Thu, Mar 11, 2021 at 3:25 PM Jan Kara wrote: > > On Thu 11-03-21 02:59:14, syzbot wrote: > > HEAD commit:a74e6a01 Merge tag 's390-5.12-3' of git://git.kernel.org/p.. > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=159f69ecd0 > > kernel config:

Re: [syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-11 Thread Jan Kara
On Thu 11-03-21 02:59:14, syzbot wrote: > HEAD commit:a74e6a01 Merge tag 's390-5.12-3' of git://git.kernel.org/p.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=159f69ecd0 > kernel config: https://syzkaller.appspot.com/x/.config?x=de394bbaade74fb7 >

[syzbot] KCSAN: data-race in start_this_handle / start_this_handle

2021-03-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a74e6a01 Merge tag 's390-5.12-3' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=159f69ecd0 kernel config: https://syzkaller.appspot.com/x/.config?x=de394bbaade74fb7 das